From fd64e220a9ef4f7adeb0140e885bb42eec0905b0 Mon Sep 17 00:00:00 2001 From: Harald Musum Date: Thu, 18 Jan 2018 14:30:18 +0100 Subject: Do not log connection errors (services may not be up, common case) --- .../config/server/filedistribution/CombinedLegacyDistribution.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java index 155479a7fd1..3b7491a503c 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java @@ -65,7 +65,7 @@ public class CombinedLegacyDistribution implements FileDistribution { request.parameters().add(new StringArray(fileReferences.stream().map(FileReference::value).toArray(String[]::new))); log.log(LogLevel.DEBUG, "Executing " + request.methodName() + " against " + target.toString()); target.invokeSync(request, timeout); - if (request.isError()) { + if (request.isError() && request.errorCode() != 104) { log.log(LogLevel.INFO, request.methodName() + " failed: " + request.errorCode() + " (" + request.errorMessage() + ")"); } } -- cgit v1.2.3 From 2459b6c4543e412db9fc183f9fcdffc54f6c0ab3 Mon Sep 17 00:00:00 2001 From: Harald Musum Date: Thu, 18 Jan 2018 17:33:58 +0100 Subject: Use a constant for error code --- .../config/server/filedistribution/CombinedLegacyDistribution.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java index 3b7491a503c..a45e6dc3b6b 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/CombinedLegacyDistribution.java @@ -3,6 +3,7 @@ package com.yahoo.vespa.config.server.filedistribution; import com.yahoo.config.FileReference; import com.yahoo.config.model.api.FileDistribution; +import com.yahoo.jrt.ErrorCode; import com.yahoo.jrt.Request; import com.yahoo.jrt.Spec; import com.yahoo.jrt.StringArray; @@ -65,7 +66,7 @@ public class CombinedLegacyDistribution implements FileDistribution { request.parameters().add(new StringArray(fileReferences.stream().map(FileReference::value).toArray(String[]::new))); log.log(LogLevel.DEBUG, "Executing " + request.methodName() + " against " + target.toString()); target.invokeSync(request, timeout); - if (request.isError() && request.errorCode() != 104) { + if (request.isError() && request.errorCode() != ErrorCode.CONNECTION) { log.log(LogLevel.INFO, request.methodName() + " failed: " + request.errorCode() + " (" + request.errorMessage() + ")"); } } -- cgit v1.2.3