From 7584971f259e6aef476aa2e596b4cbce4a3559d5 Mon Sep 17 00:00:00 2001
From: jonmv <venstad@gmail.com>
Date: Wed, 11 Oct 2023 19:45:29 +0200
Subject: Silly hack to close HTTP server before mbus server

---
 .../chain/dependencies/ordering/ChainBuilder.java  |  2 +-
 .../container/jdisc/ConfiguredApplication.java     | 30 +++++++++++++++++++---
 2 files changed, 27 insertions(+), 5 deletions(-)

diff --git a/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java b/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
index b203d7a9fb9..fef23f3cc27 100644
--- a/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
+++ b/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
@@ -46,7 +46,7 @@ public class ChainBuilder<T extends ChainedComponent> {
 
     public ChainBuilder(ComponentId id) {
         this.id = id;
-        allPhase = addPhase(new Phase("*", set("*"), Collections.<String>emptySet()));
+        allPhase = addPhase(new Phase("*", set("*"), Set.of()));
     }
 
     private Set<String> set(String... s) {
diff --git a/container-disc/src/main/java/com/yahoo/container/jdisc/ConfiguredApplication.java b/container-disc/src/main/java/com/yahoo/container/jdisc/ConfiguredApplication.java
index dca83e8e556..ab32c7683ed 100644
--- a/container-disc/src/main/java/com/yahoo/container/jdisc/ConfiguredApplication.java
+++ b/container-disc/src/main/java/com/yahoo/container/jdisc/ConfiguredApplication.java
@@ -29,6 +29,7 @@ import com.yahoo.jdisc.application.DeactivatedContainer;
 import com.yahoo.jdisc.application.GuiceRepository;
 import com.yahoo.jdisc.application.OsgiFramework;
 import com.yahoo.jdisc.handler.RequestHandler;
+import com.yahoo.jdisc.http.server.jetty.JettyHttpServer;
 import com.yahoo.jdisc.service.ClientProvider;
 import com.yahoo.jdisc.service.ServerProvider;
 import com.yahoo.jrt.Acceptor;
@@ -41,6 +42,7 @@ import com.yahoo.jrt.Supervisor;
 import com.yahoo.jrt.Transport;
 import com.yahoo.jrt.slobrok.api.Register;
 import com.yahoo.jrt.slobrok.api.SlobrokList;
+import com.yahoo.messagebus.jdisc.MbusServer;
 import com.yahoo.messagebus.network.rpc.SlobrokConfigSubscriber;
 import com.yahoo.net.HostName;
 import com.yahoo.security.tls.Capability;
@@ -53,8 +55,12 @@ import java.security.Provider;
 import java.security.Security;
 import java.time.Duration;
 import java.time.Instant;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.Comparator;
+import java.util.Deque;
 import java.util.IdentityHashMap;
 import java.util.List;
 import java.util.Map;
@@ -377,20 +383,20 @@ public final class ConfiguredApplication implements Application {
         synchronized (monitor) {
             Set<ServerProvider> serversToClose = createIdentityHashSet(startedServers);
             serversToClose.removeAll(currentServers);
-            for (ServerProvider server : currentServers) {
+            for (ServerProvider server : ordered(currentServers, MbusServer.class, JettyHttpServer.class)) {
                 if ( ! startedServers.contains(server) && server.isMultiplexed()) {
                     server.start();
                     startedServers.add(server);
                 }
             }
-            if (serversToClose.size() > 0) {
+            if ( ! serversToClose.isEmpty()) {
                 log.info(String.format("Closing %d server instances", serversToClose.size()));
-                for (ServerProvider server : serversToClose) {
+                for (ServerProvider server : ordered(serversToClose, JettyHttpServer.class, MbusServer.class)) {
                     server.close();
                     startedServers.remove(server);
                 }
             }
-            for (ServerProvider server : currentServers) {
+            for (ServerProvider server : ordered(currentServers, MbusServer.class, JettyHttpServer.class)) {
                 if ( ! startedServers.contains(server)) {
                     server.start();
                     startedServers.add(server);
@@ -525,6 +531,22 @@ public final class ConfiguredApplication implements Application {
         }
     }
 
+    /** Returns a list with the given elements, ordered by the enumerated classes, ordering more specific matches first. */
+    @SafeVarargs
+    static <T> List<T> ordered(Collection<T> items, Class<? extends T>... order) {
+        List<T> ordered = new ArrayList<>(items);
+        ordered.sort(Comparator.comparingInt(item -> {
+            int best = order.length;
+            for (int i = 0; i < order.length; i++) {
+                if (   order[i].isInstance(item)
+                    && (   best == order.length
+                        || order[best].isAssignableFrom(order[i]))) best = i;
+            }
+            return  best;
+        }));
+        return ordered;
+    }
+
     private static <E> Set<E> createIdentityHashSet() {
         return Collections.newSetFromMap(new IdentityHashMap<>());
     }
-- 
cgit v1.2.3