From 427d620bd43caedbb259a956423682e3e93f5a82 Mon Sep 17 00:00:00 2001 From: Tor Brede Vekterli Date: Tue, 27 Feb 2024 15:30:29 +0000 Subject: Add Vespa 9 deprecation comment for lazy deserialization Since the lazy deserialization captures the entire message payload, it's not independent of the protocol version used and it's therefore not safe to set or use it from any other protocol than the legacy version. --- .../com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java | 3 ++- .../com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java | 3 ++- .../yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java index 0690168f298..1704bd3827e 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java @@ -11,9 +11,10 @@ import java.nio.ByteBuffer; */ public class GetDocumentReply extends DocumentAcceptedReply { - private DocumentDeserializer buffer = null; private Document document = null; private long lastModified = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java index 04a55a6fd16..7ce25011ec1 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java @@ -14,9 +14,10 @@ import java.util.Arrays; */ public class PutDocumentMessage extends TestAndSetMessage { - private DocumentDeserializer buffer = null; private DocumentPut put = null; private long time = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java index d395353209f..3fb14664628 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java @@ -13,10 +13,11 @@ import java.util.Arrays; */ public class UpdateDocumentMessage extends TestAndSetMessage { - private DocumentDeserializer buffer = null; private DocumentUpdate update = null; private long oldTime = 0; private long newTime = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** -- cgit v1.2.3