From 850e1b6008ac7284bedea8a989670adc6a54bf2e Mon Sep 17 00:00:00 2001 From: gjoranv Date: Wed, 8 Dec 2021 17:58:57 +0100 Subject: Fix IDEA inspection issues. - Final modifiers in final class - Use primitive types where possible --- .../java/com/yahoo/jdisc/handler/FutureConjunction.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jdisc_core/src/main/java/com/yahoo/jdisc/handler/FutureConjunction.java b/jdisc_core/src/main/java/com/yahoo/jdisc/handler/FutureConjunction.java index 30d378b9479..9d0204f33c5 100644 --- a/jdisc_core/src/main/java/com/yahoo/jdisc/handler/FutureConjunction.java +++ b/jdisc_core/src/main/java/com/yahoo/jdisc/handler/FutureConjunction.java @@ -37,7 +37,7 @@ final class FutureConjunction implements ListenableFuture { } @Override - public final boolean cancel(boolean mayInterruptIfRunning) { + public boolean cancel(boolean mayInterruptIfRunning) { boolean ret = true; for (Future op : operands) { if (!op.cancel(mayInterruptIfRunning)) { @@ -48,7 +48,7 @@ final class FutureConjunction implements ListenableFuture { } @Override - public final boolean isCancelled() { + public boolean isCancelled() { for (Future op : operands) { if (!op.isCancelled()) { return false; @@ -58,7 +58,7 @@ final class FutureConjunction implements ListenableFuture { } @Override - public final boolean isDone() { + public boolean isDone() { for (Future op : operands) { if (!op.isDone()) { return false; @@ -68,8 +68,8 @@ final class FutureConjunction implements ListenableFuture { } @Override - public final Boolean get() throws InterruptedException, ExecutionException { - Boolean ret = Boolean.TRUE; + public Boolean get() throws InterruptedException, ExecutionException { + boolean ret = Boolean.TRUE; for (Future op : operands) { if (!op.get()) { ret = Boolean.FALSE; @@ -79,9 +79,9 @@ final class FutureConjunction implements ListenableFuture { } @Override - public final Boolean get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, + public Boolean get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException { - Boolean ret = Boolean.TRUE; + boolean ret = Boolean.TRUE; long nanos = unit.toNanos(timeout); long lastTime = System.nanoTime(); for (Future op : operands) { -- cgit v1.2.3