From 2fb9037bf9f6e4a2c84eda208461c6404ca0c57f Mon Sep 17 00:00:00 2001
From: jonmv <venstad@gmail.com>
Date: Fri, 17 Jun 2022 11:24:02 +0200
Subject: Avoid division by zero in success factor computation  ಠ_ಠ
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
index 5178918aa48..974345330aa 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
@@ -20,7 +20,8 @@ public class ReadyJobsTrigger extends ControllerMaintainer {
     @Override
     public double maintain() {
         TriggerResult result = controller().applications().deploymentTrigger().triggerReadyJobs();
-        return result.triggered() * 1.0f / (result.triggered() + result.failed());
+        long total = result.triggered() + result.failed();
+        return total == 0 ? 1 : (double) result.triggered() / (result.triggered() + result.failed());
     }
 
 }
-- 
cgit v1.2.3