From a8ee518242205a6e21e143aa8c3d0d8afa8e6785 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Sat, 30 Apr 2022 20:47:36 +0200 Subject: Only log when failure is unexpected. --- .../java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java index 43588f063cc..cb8e07b0282 100644 --- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java +++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java @@ -34,7 +34,9 @@ public class RemoteHealthMetricFetcher extends HttpMetricFetcher { try (InputStream stream = getJson()) { return createHealthMetrics(stream, fetchCount); } catch (IOException | InterruptedException | ExecutionException e) { - logMessageNoResponse(errMsgNoResponse(e), fetchCount); + if (service.isAlive()) { + logMessageNoResponse(errMsgNoResponse(e), fetchCount); + } return HealthMetric.getUnknown("Failed fetching metrics for service: " + service.getMonitoringName()); } } -- cgit v1.2.3 From bb53d37efdf590c0eaa47037d39849b6c31b2f03 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Sat, 30 Apr 2022 20:52:29 +0200 Subject: Silence log message since we throw anyway. --- logd/src/logd/rpc_forwarder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/logd/src/logd/rpc_forwarder.cpp b/logd/src/logd/rpc_forwarder.cpp index cd3ab1e01b5..fbd39afeba4 100644 --- a/logd/src/logd/rpc_forwarder.cpp +++ b/logd/src/logd/rpc_forwarder.cpp @@ -141,7 +141,7 @@ RpcForwarder::flush() if (!request->CheckReturnTypes("bix")) { auto error_msg = make_string("Error in rpc reply from logserver ('%s'): '%s'", _connection_spec.c_str(), request->GetErrorMessage()); - LOG(warning, "%s", error_msg.c_str()); + LOG(debug, "%s", error_msg.c_str()); throw ConnectionException(error_msg); } ProtoConverter::ProtoLogResponse proto_response; -- cgit v1.2.3