From ab05ab79a0ced00da847a1aab409a9b77b63d0aa Mon Sep 17 00:00:00 2001 From: Tor Egge Date: Sat, 28 Jan 2023 21:28:36 +0100 Subject: Remove redundant or pessimizing moves. --- .../tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp | 4 ++-- storage/src/tests/persistence/persistencetestutils.cpp | 2 +- storage/src/vespa/storage/persistence/asynchandler.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp b/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp index ca03a49ea8d..b1fda6e0efb 100644 --- a/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp +++ b/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp @@ -851,9 +851,9 @@ struct DocumentHandler gate.await(); } void putDocs() { - PutOperation putOp = createPut(std::move(createDoc(1, 22, 33)), Timestamp(10), 10); + PutOperation putOp = createPut(createDoc(1, 22, 33), Timestamp(10), 10); putDoc(putOp); - putOp = createPut(std::move(createDoc(2, 44, 55)), Timestamp(20), 20); + putOp = createPut(createDoc(2, 44, 55), Timestamp(20), 20); putDoc(putOp); } }; diff --git a/storage/src/tests/persistence/persistencetestutils.cpp b/storage/src/tests/persistence/persistencetestutils.cpp index de9caebbf11..7a92c08060c 100644 --- a/storage/src/tests/persistence/persistencetestutils.cpp +++ b/storage/src/tests/persistence/persistencetestutils.cpp @@ -245,7 +245,7 @@ PersistenceTestUtils::doPut(const document::Document::SP& doc, document::BucketI { spi::Bucket b(makeSpiBucket(bid)); getPersistenceProvider().createBucket(b); - getPersistenceProvider().put(b, time, std::move(doc)); + getPersistenceProvider().put(b, time, doc); } spi::UpdateResult diff --git a/storage/src/vespa/storage/persistence/asynchandler.cpp b/storage/src/vespa/storage/persistence/asynchandler.cpp index 70bfb0000d1..e20c0475556 100644 --- a/storage/src/vespa/storage/persistence/asynchandler.cpp +++ b/storage/src/vespa/storage/persistence/asynchandler.cpp @@ -171,7 +171,7 @@ AsyncHandler::handlePut(api::PutCommand& cmd, MessageTracker::UP trackerUP) cons tracker->checkForError(*response); tracker->sendReply(); }); - _spi.putAsync(bucket, spi::Timestamp(cmd.getTimestamp()), std::move(cmd.getDocument()), + _spi.putAsync(bucket, spi::Timestamp(cmd.getTimestamp()), cmd.getDocument(), std::make_unique(_sequencedExecutor, cmd.getBucketId(), std::move(task))); return trackerUP; @@ -300,7 +300,7 @@ AsyncHandler::handleUpdate(api::UpdateCommand& cmd, MessageTracker::UP trackerUP } tracker->sendReply(); }); - _spi.updateAsync(bucket, spi::Timestamp(cmd.getTimestamp()), std::move(cmd.getUpdate()), + _spi.updateAsync(bucket, spi::Timestamp(cmd.getTimestamp()), cmd.getUpdate(), std::make_unique(_sequencedExecutor, cmd.getBucketId(), std::move(task))); return trackerUP; } -- cgit v1.2.3