From c0a877c3325016b88f37d4c29c5a1ea1fae37ead Mon Sep 17 00:00:00 2001 From: Tor Egge Date: Wed, 6 Sep 2017 08:39:10 +0000 Subject: Move API comments from implementation headers to interface header. --- .../proton/reference/dummy_gid_to_lid_change_handler.h | 13 ------------- .../searchcore/proton/reference/gid_to_lid_change_handler.h | 12 ------------ .../proton/reference/i_gid_to_lid_change_handler.h | 11 +++++++++++ 3 files changed, 11 insertions(+), 25 deletions(-) diff --git a/searchcore/src/vespa/searchcore/proton/reference/dummy_gid_to_lid_change_handler.h b/searchcore/src/vespa/searchcore/proton/reference/dummy_gid_to_lid_change_handler.h index e0db7d1aa52..24773924aaa 100644 --- a/searchcore/src/vespa/searchcore/proton/reference/dummy_gid_to_lid_change_handler.h +++ b/searchcore/src/vespa/searchcore/proton/reference/dummy_gid_to_lid_change_handler.h @@ -24,23 +24,10 @@ public: DummyGidToLidChangeHandler(); virtual ~DummyGidToLidChangeHandler(); - /** - * Notify gid to lid mapping change. - */ virtual void notifyPut(GlobalId gid, uint32_t lid, SerialNum serialNum) override; virtual void notifyRemove(GlobalId gid, SerialNum serialNum) override; virtual void notifyRemoveDone(GlobalId gid, SerialNum serialNum) override; - - /* - * Add listener unless a listener with matching docTypeName and - * name already exists. - */ virtual void addListener(std::unique_ptr listener) override; - - /** - * Remove listeners with matching docTypeName unless name is present in - * keepNames. - */ virtual void removeListeners(const vespalib::string &docTypeName, const std::set &keepNames) override; }; diff --git a/searchcore/src/vespa/searchcore/proton/reference/gid_to_lid_change_handler.h b/searchcore/src/vespa/searchcore/proton/reference/gid_to_lid_change_handler.h index 736a34aba76..840cb61cc2a 100644 --- a/searchcore/src/vespa/searchcore/proton/reference/gid_to_lid_change_handler.h +++ b/searchcore/src/vespa/searchcore/proton/reference/gid_to_lid_change_handler.h @@ -33,9 +33,6 @@ public: GidToLidChangeHandler(); virtual ~GidToLidChangeHandler(); - /** - * Notify gid to lid mapping change. - */ virtual void notifyPut(GlobalId gid, uint32_t lid, SerialNum serialNum) override; virtual void notifyRemove(GlobalId gid, SerialNum serialNum) override; virtual void notifyRemoveDone(GlobalId gid, SerialNum serialNum) override; @@ -45,16 +42,7 @@ public: */ void close(); - /* - * Add listener unless a listener with matching docTypeName and - * name already exists. - */ virtual void addListener(std::unique_ptr listener) override; - - /** - * Remove listeners with matching docTypeName unless name is present in - * keepNames. - */ virtual void removeListeners(const vespalib::string &docTypeName, const std::set &keepNames) override; }; diff --git a/searchcore/src/vespa/searchcore/proton/reference/i_gid_to_lid_change_handler.h b/searchcore/src/vespa/searchcore/proton/reference/i_gid_to_lid_change_handler.h index a3b1db59abd..53ade83ff32 100644 --- a/searchcore/src/vespa/searchcore/proton/reference/i_gid_to_lid_change_handler.h +++ b/searchcore/src/vespa/searchcore/proton/reference/i_gid_to_lid_change_handler.h @@ -25,10 +25,21 @@ public: virtual ~IGidToLidChangeHandler() { } + /* + * Add listener unless a listener with matching docTypeName and + * name already exists. + */ virtual void addListener(std::unique_ptr listener) = 0; + /** + * Remove listeners with matching docTypeName unless name is present in + * keepNames. + */ virtual void removeListeners(const vespalib::string &docTypeName, const std::set &keepNames) = 0; + /** + * Notify gid to lid mapping change. + */ virtual void notifyPut(GlobalId gid, uint32_t lid, SerialNum serialNum) = 0; virtual void notifyRemove(GlobalId gid, SerialNum serialNum) = 0; virtual void notifyRemoveDone(GlobalId gid, SerialNum serialNum) = 0; -- cgit v1.2.3