From e4fdb0a917b1cf6e06e06e97ff1c2dece61acb09 Mon Sep 17 00:00:00 2001 From: Lester Solbakken Date: Fri, 22 Jan 2021 20:12:30 +0100 Subject: Skip, don't fail, if model can't be imported --- .../importer/configmodelview/ImportedMlModels.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/configmodelview/ImportedMlModels.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/configmodelview/ImportedMlModels.java index f847af14ed4..c6ec3724b76 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/configmodelview/ImportedMlModels.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/configmodelview/ImportedMlModels.java @@ -10,6 +10,7 @@ import java.util.Collections; import java.util.HashMap; import java.util.Map; import java.util.Optional; +import java.util.logging.Logger; /** * All models imported from the models/ directory in the application package. @@ -20,6 +21,8 @@ import java.util.Optional; */ public class ImportedMlModels { + private static final Logger log = Logger.getLogger(ImportedMlModels.class.getName()); + /** All imported models, indexed by their names */ private final Map importedModels; @@ -66,7 +69,13 @@ public class ImportedMlModels { if (existing != null) throw new IllegalArgumentException("The models in " + child + " and " + existing.source() + " both resolve to the model name '" + name + "'"); - models.put(name, importer.get().importModel(name, child)); + try { + ImportedMlModel importedModel = importer.get().importModel(name, child); + models.put(name, importedModel); + } catch (RuntimeException e) { + log.warning("Skipping import of model " + name + " as an exception occurred during import. " + + "Error: " + e.getMessage()); + } } else { importRecursively(child, models, importers); -- cgit v1.2.3