From a25e80a1761452e2065ace68ca33aa214cb89ffb Mon Sep 17 00:00:00 2001 From: Harald Musum Date: Thu, 20 Jul 2023 13:39:25 +0200 Subject: More logging at higher level, need more info --- .../vespa/clustercontroller/core/NodeStateChangeChecker.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'clustercontroller-core/src') diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java index 8453fb3450c..212748d6947 100644 --- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java +++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java @@ -39,6 +39,7 @@ import static com.yahoo.vespa.clustercontroller.core.NodeStateChangeChecker.Resu import static com.yahoo.vespa.clustercontroller.utils.staterestapi.requests.SetUnitStateRequest.Condition.FORCE; import static com.yahoo.vespa.clustercontroller.utils.staterestapi.requests.SetUnitStateRequest.Condition.SAFE; import static java.util.logging.Level.FINE; +import static java.util.logging.Level.INFO; /** * Checks if a node can be upgraded. @@ -165,6 +166,7 @@ public class NodeStateChangeChecker { if (anotherNodeInGroupAlreadyAllowed(nodeInfo, newDescription)) return allow(); } else { + log.log(INFO, "Checking if we can set " + nodeInfo.getNode() + " to maintenance temporarily"); var optionalResult = checkIfOtherNodesHaveWantedState(nodeInfo, newDescription, clusterState); if (optionalResult.isPresent()) return optionalResult.get(); @@ -243,13 +245,13 @@ public class NodeStateChangeChecker { Set groupsWithNodesWantedStateNotUp = groupsWithUserWantedStateNotUp(); if (groupsWithNodesWantedStateNotUp.size() == 0) { - log.log(FINE, "groupsWithNodesWantedStateNotUp=0"); + log.log(INFO, "groupsWithNodesWantedStateNotUp=0"); return Optional.empty(); } Set groupsWithSameStateAndDescription = groupsWithSameStateAndDescription(MAINTENANCE, newDescription); if (aGroupContainsNode(groupsWithSameStateAndDescription, node)) { - log.log(FINE, "Node is in group with same state and description, allow"); + log.log(INFO, "Node is in group with same state and description, allow"); return Optional.of(allow()); } // There are groups with nodes not up, but with another description, probably operator set @@ -271,7 +273,7 @@ public class NodeStateChangeChecker { return result; if (numberOfGroupsToConsider < maxNumberOfGroupsAllowedToBeDown) { - log.log(FINE, "Allow, retiredAndNotUpGroups=" + retiredAndNotUpGroups); + log.log(INFO, "Allow, retiredAndNotUpGroups=" + retiredAndNotUpGroups); return Optional.of(allow()); } -- cgit v1.2.3