From 097fca83b38956b887fd4f1e2cf33f4bafdea921 Mon Sep 17 00:00:00 2001
From: Bjørn Christian Seime <bjorncs@yahooinc.com>
Date: Tue, 29 Aug 2023 12:55:18 +0200
Subject: Consolidate hamcrest usage to 2.x and remove cthul-matchers

---
 clustercontroller-core/pom.xml                                         | 2 +-
 .../com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownTest.java  | 2 +-
 .../clustercontroller/core/matchers/ClusterEventWithDescription.java   | 2 --
 .../com/yahoo/vespa/clustercontroller/core/matchers/EventForNode.java  | 2 --
 .../com/yahoo/vespa/clustercontroller/core/matchers/EventTimeIs.java   | 2 --
 .../com/yahoo/vespa/clustercontroller/core/matchers/EventTypeIs.java   | 2 --
 .../yahoo/vespa/clustercontroller/core/matchers/HasMetricContext.java  | 2 --
 .../vespa/clustercontroller/core/matchers/HasStateReasonForNode.java   | 2 --
 .../vespa/clustercontroller/core/matchers/NodeEventForBucketSpace.java | 3 ---
 .../clustercontroller/core/matchers/NodeEventWithDescription.java      | 2 --
 10 files changed, 2 insertions(+), 19 deletions(-)

(limited to 'clustercontroller-core')

diff --git a/clustercontroller-core/pom.xml b/clustercontroller-core/pom.xml
index 6fc29fc811c..2f5b95b1ce1 100644
--- a/clustercontroller-core/pom.xml
+++ b/clustercontroller-core/pom.xml
@@ -43,7 +43,7 @@
         </dependency>
         <dependency>
             <groupId>org.hamcrest</groupId>
-            <artifactId>hamcrest-library</artifactId>
+            <artifactId>hamcrest</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownTest.java
index 0f9fad2c76c..fafdbbaa121 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownTest.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownTest.java
@@ -18,7 +18,7 @@ import static com.yahoo.vespa.clustercontroller.core.matchers.EventForNode.event
 import static com.yahoo.vespa.clustercontroller.core.matchers.NodeEventWithDescription.nodeEventWithDescription;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.AllOf.allOf;
-import static org.hamcrest.core.IsCollectionContaining.hasItem;
+import static org.hamcrest.core.IsIterableContaining.hasItem;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/ClusterEventWithDescription.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/ClusterEventWithDescription.java
index 9dc2fd97718..baaeeccf12c 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/ClusterEventWithDescription.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/ClusterEventWithDescription.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.core.ClusterEvent;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 public class ClusterEventWithDescription extends BaseMatcher<ClusterEvent> {
     private final String expected;
@@ -35,7 +34,6 @@ public class ClusterEventWithDescription extends BaseMatcher<ClusterEvent> {
         description.appendText(String.format("got description '%s'", other.getDescription()));
     }
 
-    @Factory
     public static ClusterEventWithDescription clusterEventWithDescription(String description) {
         return new ClusterEventWithDescription(description);
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventForNode.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventForNode.java
index 8ce0b52ee8b..55be4dbd709 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventForNode.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventForNode.java
@@ -5,7 +5,6 @@ import com.yahoo.vdslib.state.Node;
 import com.yahoo.vespa.clustercontroller.core.NodeEvent;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 public class EventForNode extends BaseMatcher<NodeEvent> {
     private final Node expected;
@@ -30,7 +29,6 @@ public class EventForNode extends BaseMatcher<NodeEvent> {
         description.appendText(String.format("got node %s", other.getNode().getNode()));
     }
 
-    @Factory
     public static EventForNode eventForNode(Node expected) {
         return new EventForNode(expected);
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTimeIs.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTimeIs.java
index 42a89b301fe..bcc02e1f4db 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTimeIs.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTimeIs.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.core.Event;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 public class EventTimeIs extends BaseMatcher<Event> {
     private final long expected;
@@ -32,7 +31,6 @@ public class EventTimeIs extends BaseMatcher<Event> {
         description.appendText(String.format("event time is %d", other.getTimeMs()));
     }
 
-    @Factory
     public static EventTimeIs eventTimeIs(long time) {
         return new EventTimeIs(time);
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTypeIs.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTypeIs.java
index 59a532763b0..228723e2fef 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTypeIs.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/EventTypeIs.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.core.NodeEvent;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 public class EventTypeIs extends BaseMatcher<NodeEvent> {
     private final NodeEvent.Type expected;
@@ -32,7 +31,6 @@ public class EventTypeIs extends BaseMatcher<NodeEvent> {
         description.appendText(String.format("got description '%s'", other.getDescription()));
     }
 
-    @Factory
     public static EventTypeIs eventTypeIs(NodeEvent.Type type) {
         return new EventTypeIs(type);
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasMetricContext.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasMetricContext.java
index 92123752465..95a1d9f1a28 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasMetricContext.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasMetricContext.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.utils.util.MetricReporter;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 import java.util.Map;
 import java.util.TreeMap;
@@ -64,7 +63,6 @@ public class HasMetricContext extends BaseMatcher<MetricReporter.Context> {
         return new Dimension(name, value);
     }
 
-    @Factory
     public static HasMetricContext hasMetricContext(Dimension... dimensions) {
         return new HasMetricContext(Stream.of(dimensions).collect(Collectors.toMap(dim -> dim.name, dim -> dim.value)));
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasStateReasonForNode.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasStateReasonForNode.java
index 72f51e21c5a..bf87f58692b 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasStateReasonForNode.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/HasStateReasonForNode.java
@@ -5,7 +5,6 @@ import com.yahoo.vdslib.state.Node;
 import com.yahoo.vespa.clustercontroller.core.NodeStateReason;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 import java.util.Map;
 
@@ -42,7 +41,6 @@ public class HasStateReasonForNode extends BaseMatcher<Map<Node, NodeStateReason
         }
     }
 
-    @Factory
     public static HasStateReasonForNode hasStateReasonForNode(Node node, NodeStateReason reason) {
         return new HasStateReasonForNode(node, reason);
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventForBucketSpace.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventForBucketSpace.java
index e479e031f10..9951bf50f5c 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventForBucketSpace.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventForBucketSpace.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.core.NodeEvent;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 import java.util.Optional;
 
@@ -34,12 +33,10 @@ public class NodeEventForBucketSpace extends BaseMatcher<NodeEvent> {
         description.appendText(String.format("got bucket space '%s'", other.getBucketSpace().orElse("null")));
     }
 
-    @Factory
     public static NodeEventForBucketSpace nodeEventForBucketSpace(String bucketSpace) {
         return new NodeEventForBucketSpace(Optional.of(bucketSpace));
     }
 
-    @Factory
     public static NodeEventForBucketSpace nodeEventForBaseline() {
         return new NodeEventForBucketSpace(Optional.empty());
     }
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventWithDescription.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventWithDescription.java
index b070fa27817..ca5720797e2 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventWithDescription.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/matchers/NodeEventWithDescription.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.matchers;
 import com.yahoo.vespa.clustercontroller.core.NodeEvent;
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
-import org.hamcrest.Factory;
 
 public class NodeEventWithDescription extends BaseMatcher<NodeEvent> {
     private final String expected;
@@ -35,7 +34,6 @@ public class NodeEventWithDescription extends BaseMatcher<NodeEvent> {
         description.appendText(String.format("got description '%s'", other.getDescription()));
     }
 
-    @Factory
     public static NodeEventWithDescription nodeEventWithDescription(String description) {
         return new NodeEventWithDescription(description);
     }
-- 
cgit v1.2.3