From d0b778a6301f52dc8859ef5938cf36baded302c1 Mon Sep 17 00:00:00 2001 From: Øyvind Grønnesby Date: Fri, 31 May 2019 13:01:00 +0200 Subject: Throw an exception if a region is mentioned multiple times for an endpoint --- .../yahoo/config/application/api/xml/DeploymentSpecXmlReader.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'config-model-api') diff --git a/config-model-api/src/main/java/com/yahoo/config/application/api/xml/DeploymentSpecXmlReader.java b/config-model-api/src/main/java/com/yahoo/config/application/api/xml/DeploymentSpecXmlReader.java index 1078317e0d2..58795f6ea9e 100644 --- a/config-model-api/src/main/java/com/yahoo/config/application/api/xml/DeploymentSpecXmlReader.java +++ b/config-model-api/src/main/java/com/yahoo/config/application/api/xml/DeploymentSpecXmlReader.java @@ -177,7 +177,10 @@ public class DeploymentSpecXmlReader { if (region == null || region.isEmpty() || region.isBlank()) { throw new IllegalArgumentException("Empty 'region' element in 'endpoint' tag."); } - regions.add(regionElement.getTextContent()); + if (regions.contains(region)) { + throw new IllegalArgumentException("Duplicate 'region' element in 'endpoint' tag: " + region); + } + regions.add(region); } endpoints.add(new Endpoint(rotationId, containerId.get(), regions)); -- cgit v1.2.3