From afe0fef2ec41bbc8594a8d8e565ab342d27a3164 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Fri, 8 Mar 2024 17:12:26 +0100 Subject: Avoid reflection magic --- .../java/com/yahoo/schema/derived/RankProfileList.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'config-model/src/main/java/com/yahoo/schema/derived/RankProfileList.java') diff --git a/config-model/src/main/java/com/yahoo/schema/derived/RankProfileList.java b/config-model/src/main/java/com/yahoo/schema/derived/RankProfileList.java index 33779a718db..b08629d68a3 100644 --- a/config-model/src/main/java/com/yahoo/schema/derived/RankProfileList.java +++ b/config-model/src/main/java/com/yahoo/schema/derived/RankProfileList.java @@ -17,6 +17,7 @@ import com.yahoo.vespa.config.search.core.OnnxModelsConfig; import com.yahoo.vespa.config.search.core.RankingConstantsConfig; import com.yahoo.vespa.config.search.core.RankingExpressionsConfig; +import java.io.IOException; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; @@ -33,8 +34,7 @@ import java.util.concurrent.Future; * * @author bratseth */ -//TODO Remove implements RankProfilesConfig.Producer, that is only necessary due to some test magic -public class RankProfileList extends Derived implements RankProfilesConfig.Producer { +public class RankProfileList extends Derived { private final Map rankProfiles; private final FileDistributedConstants constants; @@ -194,10 +194,12 @@ public class RankProfileList extends Derived implements RankProfilesConfig.Produ @Override public String getDerivedName() { return "rank-profiles"; } - @Override - public void getConfig(RankProfilesConfig.Builder builder) { - // Replace - builder.rankprofile(rankProfiles.values().stream().map(RawRankProfile::getConfig).toList()); + public void export(String toDirectory) throws IOException { + export(toDirectory, new RankProfilesConfig.Builder().rankprofile(getRankProfilesConfig()).build()); + } + + public List getRankProfilesConfig() { + return rankProfiles.values().stream().map(RawRankProfile::getConfig).toList(); } private static RankingExpressionsConfig.Expression.Builder toConfig(RankingExpressionBody expr) { -- cgit v1.2.3