From 1081269ed0e31e22f44d6bc87c66d4b30fda52f7 Mon Sep 17 00:00:00 2001 From: Jon Bratseth Date: Tue, 29 Jan 2019 16:12:14 +0100 Subject: Cleanup and simplify slightly --- .../processing/AdjustPositionSummaryFields.java | 14 ++++++++++---- .../searchdefinition/processing/ImplicitSummaries.java | 3 +-- 2 files changed, 11 insertions(+), 6 deletions(-) (limited to 'config-model/src') diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/processing/AdjustPositionSummaryFields.java b/config-model/src/main/java/com/yahoo/searchdefinition/processing/AdjustPositionSummaryFields.java index e59fcdf3dd0..6e089d6155b 100644 --- a/config-model/src/main/java/com/yahoo/searchdefinition/processing/AdjustPositionSummaryFields.java +++ b/config-model/src/main/java/com/yahoo/searchdefinition/processing/AdjustPositionSummaryFields.java @@ -69,10 +69,16 @@ public class AdjustPositionSummaryFields extends Processor { summaryField.setTransform(SummaryTransform.GEOPOS); summaryField.getSources().clear(); summaryField.addSource(source); - ensureSummaryField(summary, PositionDataType.getPositionSummaryFieldName(summaryField.getName()), - DataType.getArray(DataType.STRING), source, SummaryTransform.POSITIONS); - ensureSummaryField(summary, PositionDataType.getDistanceSummaryFieldName(summaryField.getName()), - DataType.INT, source, SummaryTransform.DISTANCE); + ensureSummaryField(summary, + PositionDataType.getPositionSummaryFieldName(summaryField.getName()), + DataType.getArray(DataType.STRING), + source, + SummaryTransform.POSITIONS); + ensureSummaryField(summary, + PositionDataType.getDistanceSummaryFieldName(summaryField.getName()), + DataType.INT, + source, + SummaryTransform.DISTANCE); } private void ensureSummaryField(DocumentSummary summary, String fieldName, DataType dataType, Source source, SummaryTransform transform) { diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/processing/ImplicitSummaries.java b/config-model/src/main/java/com/yahoo/searchdefinition/processing/ImplicitSummaries.java index 2e6187d4545..eddb0adb8d6 100644 --- a/config-model/src/main/java/com/yahoo/searchdefinition/processing/ImplicitSummaries.java +++ b/config-model/src/main/java/com/yahoo/searchdefinition/processing/ImplicitSummaries.java @@ -145,8 +145,7 @@ public class ImplicitSummaries extends Processor { // Returns whether this is valid. Warns if invalid and ignorable. Throws if not ignorable. private boolean isValid(SummaryField summaryField, Search search, boolean validate) { if (summaryField.getTransform() == SummaryTransform.DISTANCE || - summaryField.getTransform() == SummaryTransform.POSITIONS) - { + summaryField.getTransform() == SummaryTransform.POSITIONS) { int sourceCount = summaryField.getSourceCount(); if (validate && sourceCount != 1) { throw newProcessException(search.getName(), summaryField.getName(), -- cgit v1.2.3