From 425499a703d034d6144255689102e86c1557b157 Mon Sep 17 00:00:00 2001
From: Valerij Fredriksen <valerijf@verizonmedia.com>
Date: Fri, 11 Oct 2019 12:57:56 +0200
Subject: Move FlagRepository to flags

---
 .../src/main/java/com/yahoo/vespa/configserver/flags/FlagsDb.java  | 7 ++-----
 .../java/com/yahoo/vespa/configserver/flags/db/FlagsDbImpl.java    | 2 +-
 .../java/com/yahoo/vespa/configserver/flags/http/FlagsHandler.java | 2 +-
 .../com/yahoo/vespa/configserver/flags/db/FlagsDbImplTest.java     | 2 +-
 4 files changed, 5 insertions(+), 8 deletions(-)

(limited to 'configserver-flags')

diff --git a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/FlagsDb.java b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/FlagsDb.java
index 2c29ae0b818..6ccb2a61b56 100644
--- a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/FlagsDb.java
+++ b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/FlagsDb.java
@@ -2,15 +2,15 @@
 package com.yahoo.vespa.configserver.flags;
 
 import com.yahoo.vespa.flags.FlagId;
+import com.yahoo.vespa.flags.FlagRepository;
 import com.yahoo.vespa.flags.json.FlagData;
 
-import java.util.Map;
 import java.util.Optional;
 
 /**
  * @author hakonhall
  */
-public interface FlagsDb {
+public interface FlagsDb extends FlagRepository {
     /** Get the String value of the flag. */
     Optional<FlagData> getValue(FlagId flagId);
 
@@ -19,7 +19,4 @@ public interface FlagsDb {
 
     /** Remove the flag value if it exists. */
     void removeValue(FlagId flagId);
-
-    /** Get all flags that have been set. */
-    Map<FlagId, FlagData> getAllFlags();
 }
diff --git a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImpl.java b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImpl.java
index 5058358ba03..66423492a73 100644
--- a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImpl.java
+++ b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImpl.java
@@ -48,7 +48,7 @@ public class FlagsDbImpl implements FlagsDb {
     }
 
     @Override
-    public Map<FlagId, FlagData> getAllFlags() {
+    public Map<FlagId, FlagData> getAllFlagData() {
         List<ChildData> dataList = cache.getCurrentData();
         return dataList.stream()
                 .map(ChildData::getData)
diff --git a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/http/FlagsHandler.java b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/http/FlagsHandler.java
index 8810a13f909..d34b1fd949f 100644
--- a/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/http/FlagsHandler.java
+++ b/configserver-flags/src/main/java/com/yahoo/vespa/configserver/flags/http/FlagsHandler.java
@@ -90,7 +90,7 @@ public class FlagsHandler extends LoggingRequestHandler {
     }
 
     private HttpResponse getFlagDataList(HttpRequest request) {
-        return new FlagDataListResponse(flagsV1Uri(request), flagsDb.getAllFlags(),
+        return new FlagDataListResponse(flagsV1Uri(request), flagsDb.getAllFlagData(),
                                         Objects.equals(request.getProperty("recursive"), "true"));
     }
 
diff --git a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImplTest.java b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImplTest.java
index ecc9bacb081..7460e42c866 100644
--- a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImplTest.java
+++ b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/db/FlagsDbImplTest.java
@@ -45,7 +45,7 @@ public class FlagsDbImplTest {
         FlagId flagId2 = new FlagId("id2");
         FlagData data2 = new FlagData(flagId2, new FetchVector().with(FetchVector.Dimension.ZONE_ID, "zone-a"), rule1);
         db.setValue(flagId2, data2);
-        Map<FlagId, FlagData> flags = db.getAllFlags();
+        Map<FlagId, FlagData> flags = db.getAllFlagData();
         assertThat(flags.size(), equalTo(2));
         assertThat(flags.get(flagId), notNullValue());
         assertThat(flags.get(flagId2), notNullValue());
-- 
cgit v1.2.3