From 0769d4e04be5f9032f8699cdfa8b6c208645d3a3 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Sat, 3 Dec 2022 17:22:00 +0100 Subject: Avoid sorting an unmodifiable list --- .../com/yahoo/vespa/config/server/ApplicationRepositoryTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'configserver/src') diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java index 74ec5e81da3..2e60a6c6cd0 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java @@ -295,10 +295,8 @@ public class ApplicationRepositoryTest { // deployApp(new File("src/test/apps/app"), prepareParams); List deleted = applicationRepository.deleteUnusedFileDistributionReferences(fileDirectory, keepFileReferencesDuration); - Collections.sort(deleted); - List expected = new ArrayList<>(List.of("bar", "baz0", "baz1")); - Collections.sort(expected); - assertEquals(expected, deleted); + List expected = List.of("bar", "baz0", "baz1"); + assertEquals(expected.stream().sorted().toList(), deleted.stream().sorted().toList()); // bar, baz0 and baz1 will be deleted and foo is not old enough to be considered assertFalse(filereferenceDirOldest.exists()); assertFalse(new File(fileReferencesDir, "baz0").exists()); -- cgit v1.2.3