From 32c8299692736b66c31a93f3f18d1921b559a298 Mon Sep 17 00:00:00 2001 From: Harald Musum Date: Tue, 12 Mar 2019 11:41:31 +0100 Subject: Revert "Set generation in empty sentinel config response" --- .../main/java/com/yahoo/vespa/config/server/rpc/GetConfigProcessor.java | 2 +- .../src/test/java/com/yahoo/vespa/config/server/rpc/RpcServerTest.java | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'configserver') diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/rpc/GetConfigProcessor.java b/configserver/src/main/java/com/yahoo/vespa/config/server/rpc/GetConfigProcessor.java index bebd0b341db..bbdef71129a 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/rpc/GetConfigProcessor.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/rpc/GetConfigProcessor.java @@ -167,7 +167,7 @@ class GetConfigProcessor implements Runnable { log.log(LogLevel.INFO, "Returning empty sentinel config for request from " + request.getClientHostName()); ConfigPayload emptyPayload = ConfigPayload.empty(); String configMd5 = ConfigUtils.getMd5(emptyPayload); - ConfigResponse config = SlimeConfigResponse.fromConfigPayload(emptyPayload, null, request.getRequestGeneration() + 1, false, configMd5); + ConfigResponse config = SlimeConfigResponse.fromConfigPayload(emptyPayload, null, 0, false, configMd5); request.addOkResponse(request.payloadFromResponse(config), config.getGeneration(), false, config.getConfigMd5()); respond(request); } diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/rpc/RpcServerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/rpc/RpcServerTest.java index 959b284220b..c8bc9364922 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/rpc/RpcServerTest.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/rpc/RpcServerTest.java @@ -96,8 +96,6 @@ public class RpcServerTest { new ConfigPayloadApplier<>(builder).applyPayload(payload); SentinelConfig config = new SentinelConfig(builder); assertEquals(0, config.service().size()); - // Test generation explicitly since it is not set set the usual way - assertTrue(clientReq.getNewGeneration() > clientReq.getRequestGeneration()); } } -- cgit v1.2.3