From 34d35c3467aebeda68c3d58ccfb683c0f4f0c506 Mon Sep 17 00:00:00 2001 From: Harald Musum Date: Wed, 11 Oct 2023 18:53:38 +0200 Subject: Revert "Jonmv/job runner thread metrics" --- .../yahoo/container/handler/threadpool/ContainerThreadpoolImpl.java | 2 +- .../handler/threadpool/WorkerCompletionTimingThreadPoolExecutor.java | 3 ++- .../src/main/java/com/yahoo/container/protect/ProcessTerminator.java | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) (limited to 'container-core/src/main/java/com/yahoo/container') diff --git a/container-core/src/main/java/com/yahoo/container/handler/threadpool/ContainerThreadpoolImpl.java b/container-core/src/main/java/com/yahoo/container/handler/threadpool/ContainerThreadpoolImpl.java index f92d218390f..befbda28ac0 100644 --- a/container-core/src/main/java/com/yahoo/container/handler/threadpool/ContainerThreadpoolImpl.java +++ b/container-core/src/main/java/com/yahoo/container/handler/threadpool/ContainerThreadpoolImpl.java @@ -54,7 +54,7 @@ public class ContainerThreadpoolImpl extends AbstractComponent implements AutoCl createQueue(queueSize), ThreadFactoryFactory.getThreadFactory(name), threadPoolMetric); - // Pre-start needed, if not all threads will be created by the fist N tasks and hence they might also + // Prestart needed, if not all threads will be created by the fist N tasks and hence they might also // get the dreaded thread locals initialized even if they will never run. // That counters what we want to achieve with the Q that will prefer thread locality. executor.prestartAllCoreThreads(); diff --git a/container-core/src/main/java/com/yahoo/container/handler/threadpool/WorkerCompletionTimingThreadPoolExecutor.java b/container-core/src/main/java/com/yahoo/container/handler/threadpool/WorkerCompletionTimingThreadPoolExecutor.java index cee2cc54b5b..e3c2c78abec 100644 --- a/container-core/src/main/java/com/yahoo/container/handler/threadpool/WorkerCompletionTimingThreadPoolExecutor.java +++ b/container-core/src/main/java/com/yahoo/container/handler/threadpool/WorkerCompletionTimingThreadPoolExecutor.java @@ -8,7 +8,8 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicLong; /** - * A thread pool executor which maintains the last time a worker completed. + * A thread pool executor which maintains the last time a worker completed + * package private for testing * * @author Steinar Knutsen * @author baldersheim diff --git a/container-core/src/main/java/com/yahoo/container/protect/ProcessTerminator.java b/container-core/src/main/java/com/yahoo/container/protect/ProcessTerminator.java index 3c44ba2eaa6..315dc21ec38 100644 --- a/container-core/src/main/java/com/yahoo/container/protect/ProcessTerminator.java +++ b/container-core/src/main/java/com/yahoo/container/protect/ProcessTerminator.java @@ -4,8 +4,8 @@ package com.yahoo.container.protect; import com.yahoo.protect.Process; /** - * An injectable terminator of the Java VM. - * Components that encounter conditions where the VM should be terminated should + * An injectable terminator of the Java vm. + * Components that encounters conditions where the vm should be terminated should * request an instance of this injected. That makes termination testable * as tests can create subclasses of this which register the termination request * rather than terminating. -- cgit v1.2.3