From 62ed862f1f66350173a8e0606d2e5f25fab83b93 Mon Sep 17 00:00:00 2001 From: gjoranv Date: Thu, 8 Sep 2022 14:19:55 +0200 Subject: Update stale comments after refactoring the code. --- .../com/yahoo/container/core/config/ApplicationBundleLoader.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'container-core/src/main') diff --git a/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java b/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java index 88e66c45ca3..cf3db91239a 100644 --- a/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java +++ b/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java @@ -66,6 +66,9 @@ public class ApplicationBundleLoader { readyForNewBundles = false; } + /** + * Must be called after useBundles() to report success or failure for the latest bundle generation. + */ public synchronized Set completeGeneration(GenerationStatus status) { Set ret = Set.of(); if (readyForNewBundles) return ret; @@ -79,10 +82,8 @@ public class ApplicationBundleLoader { } /** - * Commit to the current set of bundles. Must be called after the component graph creation proved successful, - * to prevent uninstalling bundles unintentionally upon a future call to {@link #revertToPreviousGeneration()}. - * Returns the set of bundles that is no longer used by the application, and should therefore be scheduled - * for uninstall. + * Commit to the latest set of bundles given to useBundles(). Returns the set of bundles that is no longer + * used by the application, and should therefore be scheduled for uninstall. */ private Set commitBundles() { var bundlesToUninstall = new LinkedHashSet<>(obsoleteBundles.values()); -- cgit v1.2.3