From ad242c78f226f8258d4565459bb97d8ddf3911dc Mon Sep 17 00:00:00 2001 From: Håkon Hallingstad Date: Sat, 8 Jun 2019 00:52:57 +0200 Subject: Deconstruct component graph at end of test The container-search, QueryProfileIntegrationTestCase tests writes a lot of warnings of the following form: WARNING: com.yahoo.config.subscription.ConfigSubscriber@515b8b03: Closing subscription from finalizer() - close() has not been called (keys=[name=components,namespace=container,configId=dir:src/test/java/com/yahoo/search/query/profile/config/test/typed, name=bundles,namespace=container,configId=dir:src/test/java/com/yahoo/search/query/profile/config/test/typed]) java.lang.Throwable at com.yahoo.config.subscription.ConfigSubscriber.(ConfigSubscriber.java:73) at com.yahoo.container.di.CloudSubscriberFactory$CloudSubscriber.(CloudSubscriberFactory.java:76) at com.yahoo.container.di.CloudSubscriberFactory.getSubscriber(CloudSubscriberFactory.java:48) at com.yahoo.container.di.ConfigRetriever.(ConfigRetriever.java:43) at com.yahoo.container.di.Container.(Container.java:60) at com.yahoo.container.core.config.HandlersConfigurerDi.(HandlersConfigurerDi.java:87) at com.yahoo.container.core.config.testutil.HandlersConfigurerTestWrapper.(HandlersConfigurerTestWrapper.java:99) at com.yahoo.search.query.profile.config.test.QueryProfileIntegrationTestCase.testTyped(QueryProfileIntegrationTestCase.java:82) This PR ensures the configurer is shutdown if the test wrapper is shutdown. --- .../container/core/config/testutil/HandlersConfigurerTestWrapper.java | 1 + 1 file changed, 1 insertion(+) (limited to 'container-core') diff --git a/container-core/src/main/java/com/yahoo/container/core/config/testutil/HandlersConfigurerTestWrapper.java b/container-core/src/main/java/com/yahoo/container/core/config/testutil/HandlersConfigurerTestWrapper.java index 1c3b9088a95..1fd90125cde 100644 --- a/container-core/src/main/java/com/yahoo/container/core/config/testutil/HandlersConfigurerTestWrapper.java +++ b/container-core/src/main/java/com/yahoo/container/core/config/testutil/HandlersConfigurerTestWrapper.java @@ -119,6 +119,7 @@ public class HandlersConfigurerTestWrapper { } public void shutdown() { + configurer.shutdown(getTestDeconstructor()); // TODO: Remove once tests use ConfigSet rather than dir: for (File f : createdFiles) { f.delete(); -- cgit v1.2.3