From e764aaebe9139046da77557689b6eaa712719df0 Mon Sep 17 00:00:00 2001 From: Jon Bratseth Date: Thu, 7 Apr 2022 21:45:14 +0200 Subject: No functional changes --- .../yahoo/search/grouping/UniqueGroupingSearcher.java | 1 + .../com/yahoo/search/grouping/result/GroupList.java | 2 +- .../search/grouping/UniqueGroupingSearcherTestCase.java | 17 +++++++++-------- 3 files changed, 11 insertions(+), 9 deletions(-) (limited to 'container-search') diff --git a/container-search/src/main/java/com/yahoo/search/grouping/UniqueGroupingSearcher.java b/container-search/src/main/java/com/yahoo/search/grouping/UniqueGroupingSearcher.java index 2f1668245da..a1446367f79 100644 --- a/container-search/src/main/java/com/yahoo/search/grouping/UniqueGroupingSearcher.java +++ b/container-search/src/main/java/com/yahoo/search/grouping/UniqueGroupingSearcher.java @@ -276,4 +276,5 @@ public class UniqueGroupingSearcher extends Searcher { .setLabel(LABEL_HITS) .addOutput(summaryClass == null ? new SummaryValue() : new SummaryValue(summaryClass)))))); } + } diff --git a/container-search/src/main/java/com/yahoo/search/grouping/result/GroupList.java b/container-search/src/main/java/com/yahoo/search/grouping/result/GroupList.java index d3d48358bc5..7d3228588d4 100644 --- a/container-search/src/main/java/com/yahoo/search/grouping/result/GroupList.java +++ b/container-search/src/main/java/com/yahoo/search/grouping/result/GroupList.java @@ -5,7 +5,7 @@ import com.yahoo.search.Result; import com.yahoo.search.grouping.GroupingRequest; /** - * This class represents a labeled group list in the grouping result model. It is contained in {@link Group}, and + * A labeled group list in the grouping result model. It is contained in {@link Group}, and * contains one or more {@link Group groups} itself, allowing for a hierarchy of grouping results. Use the {@link * GroupingRequest#getResultGroup(Result)} to retrieve grouping results. * diff --git a/container-search/src/test/java/com/yahoo/search/grouping/UniqueGroupingSearcherTestCase.java b/container-search/src/test/java/com/yahoo/search/grouping/UniqueGroupingSearcherTestCase.java index bcade5aa1cc..cb771ecb678 100644 --- a/container-search/src/test/java/com/yahoo/search/grouping/UniqueGroupingSearcherTestCase.java +++ b/container-search/src/test/java/com/yahoo/search/grouping/UniqueGroupingSearcherTestCase.java @@ -27,14 +27,14 @@ import static org.junit.Assert.fail; public class UniqueGroupingSearcherTestCase { @Test - public void testSkipGroupingBasedDedup() throws Exception { + public void testSkipGroupingBasedDedup() { Result result = search("?query=foo", new MockResultProvider(0, false)); assertEquals(0, result.hits().size()); } @Test - public void testSkipGroupingBasedDedupIfMultiLevelSorting() throws Exception { + public void testSkipGroupingBasedDedupIfMultiLevelSorting() { Result result = search("?query=foo&unique=fingerprint&sorting=-pubdate%20-[rank]", new MockResultProvider(0, false)); assertEquals(0, result.hits().size()); @@ -55,14 +55,14 @@ public class UniqueGroupingSearcherTestCase { } @Test - public void testGroupingBasedDedupNoGroupingHits() throws Exception { + public void testGroupingBasedDedupNoGroupingHits() { Result result = search("?query=foo&unique=fingerprint", new MockResultProvider(0, true)); assertEquals(0, result.hits().size()); } @Test - public void testGroupingBasedDedupWithEmptyGroupingHitsList() throws Exception { + public void testGroupingBasedDedupWithEmptyGroupingHitsList() { Result result = search("?query=foo&unique=fingerprint", new MockResultProvider(0, true).addGroupList(new GroupList("fingerprint"))); assertEquals(0, result.hits().size()); @@ -70,7 +70,7 @@ public class UniqueGroupingSearcherTestCase { } @Test - public void testGroupingBasedDedupWithNullGroupingResult() throws Exception { + public void testGroupingBasedDedupWithNullGroupingResult() { try { search("?query=foo&unique=fingerprint", new MockResultProvider(0, false)); @@ -81,7 +81,7 @@ public class UniqueGroupingSearcherTestCase { } @Test - public void testGroupingBasedDedupWithGroupingHits() throws Exception { + public void testGroupingBasedDedupWithGroupingHits() { GroupList fingerprint = new GroupList("fingerprint"); fingerprint.add(makeHitGroup("1")); fingerprint.add(makeHitGroup("2")); @@ -105,7 +105,7 @@ public class UniqueGroupingSearcherTestCase { } @Test - public void testGroupingBasedDedupWithGroupingHitsAndSorting() throws Exception { + public void testGroupingBasedDedupWithGroupingHitsAndSorting() { GroupList fingerprint = new GroupList("fingerprint"); fingerprint.add(makeSortingHitGroup("1")); fingerprint.add(makeSortingHitGroup("2")); @@ -130,7 +130,7 @@ public class UniqueGroupingSearcherTestCase { } @Test - public void testBuildGroupingExpression() throws Exception { + public void testBuildGroupingExpression() { assertEquals("all(group(title) max(11) output(count() as(uniqueCount)) each(max(1) each(output(summary())) " + "as(uniqueHits)))", UniqueGroupingSearcher @@ -212,4 +212,5 @@ public class UniqueGroupingSearcherTestCase { return result; } } + } -- cgit v1.2.3