From 5afcac52c9e22341e02332e27537cb1520917678 Mon Sep 17 00:00:00 2001 From: Valerij Fredriksen Date: Mon, 15 Nov 2021 12:49:33 +0100 Subject: Simplify deployedDirectly serialization --- .../vespa/hosted/controller/persistence/ApplicationSerializer.java | 5 +---- .../com/yahoo/vespa/hosted/controller/persistence/RunSerializer.java | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) (limited to 'controller-server') diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java index 2f9c8488668..e8a7f7729fb 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java @@ -423,10 +423,7 @@ public class ApplicationSerializer { Optional buildTime = SlimeUtils.optionalInstant(object.field(buildTimeField)); Optional sourceUrl = SlimeUtils.optionalString(object.field(sourceUrlField)); Optional commit = SlimeUtils.optionalString(object.field(commitField)); - - // TODO (freva): Simplify once this has rolled out everywhere - Inspector deployedDirectlyInspector = object.field(deployedDirectlyField); - boolean deployedDirectly = deployedDirectlyInspector.valid() && deployedDirectlyInspector.asBool(); + boolean deployedDirectly = object.field(deployedDirectlyField).asBool(); return new ApplicationVersion(sourceRevision, applicationBuildNumber, authorEmail, compileVersion, buildTime, sourceUrl, commit, deployedDirectly); } diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/RunSerializer.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/RunSerializer.java index 6af3978d0cd..289d6c3a99d 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/RunSerializer.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/persistence/RunSerializer.java @@ -177,10 +177,7 @@ class RunSerializer { Optional buildTime = SlimeUtils.optionalInstant(versionObject.field(buildTimeField)); Optional sourceUrl = SlimeUtils.optionalString(versionObject.field(sourceUrlField)); Optional commit = SlimeUtils.optionalString(versionObject.field(commitField)); - - // TODO (freva): Simplify once this has rolled out everywhere - Inspector deployedDirectlyInspector = versionObject.field(deployedDirectlyField); - boolean deployedDirectly = deployedDirectlyInspector.valid() && deployedDirectlyInspector.asBool(); + boolean deployedDirectly = versionObject.field(deployedDirectlyField).asBool(); return new ApplicationVersion(source, OptionalLong.of(buildNumber), authorEmail, compileVersion, buildTime, sourceUrl, commit, deployedDirectly); -- cgit v1.2.3