From 8993b9df81bf0acbbe42db002a202f46f019e7e6 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Thu, 27 Apr 2023 14:30:27 +0200 Subject: Unify passing of all feed operations through the various feed apis. --- .../yahoo/vespaxmlparser/DocumentFeedOperation.java | 20 +++++++------------- .../vespaxmlparser/DocumentUpdateFeedOperation.java | 7 +------ .../java/com/yahoo/vespaxmlparser/FeedOperation.java | 12 ++++++------ .../yahoo/vespaxmlparser/RemoveFeedOperation.java | 17 +++++++---------- .../com/yahoo/vespaxmlparser/VespaXMLFeedReader.java | 14 ++++++++++---- 5 files changed, 31 insertions(+), 39 deletions(-) (limited to 'document/src/main/java/com/yahoo/vespaxmlparser') diff --git a/document/src/main/java/com/yahoo/vespaxmlparser/DocumentFeedOperation.java b/document/src/main/java/com/yahoo/vespaxmlparser/DocumentFeedOperation.java index 5edb066ddaf..7a62bd92f37 100644 --- a/document/src/main/java/com/yahoo/vespaxmlparser/DocumentFeedOperation.java +++ b/document/src/main/java/com/yahoo/vespaxmlparser/DocumentFeedOperation.java @@ -1,26 +1,20 @@ // Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. package com.yahoo.vespaxmlparser; -import com.yahoo.document.Document; -import com.yahoo.document.TestAndSetCondition; +import com.yahoo.document.DocumentPut; public class DocumentFeedOperation extends ConditionalFeedOperation { - private final Document document; + private final DocumentPut put; - public DocumentFeedOperation(Document document) { - super(Type.DOCUMENT); - this.document = document; - } - - public DocumentFeedOperation(Document document, TestAndSetCondition condition) { - super(Type.DOCUMENT, condition); - this.document = document; + public DocumentFeedOperation(DocumentPut put) { + super(Type.DOCUMENT, put.getCondition()); + this.put = put; } @Override - public Document getDocument() { - return document; + public DocumentPut getDocumentPut() { + return put; } } diff --git a/document/src/main/java/com/yahoo/vespaxmlparser/DocumentUpdateFeedOperation.java b/document/src/main/java/com/yahoo/vespaxmlparser/DocumentUpdateFeedOperation.java index 59611a7d083..c8b57dbce45 100644 --- a/document/src/main/java/com/yahoo/vespaxmlparser/DocumentUpdateFeedOperation.java +++ b/document/src/main/java/com/yahoo/vespaxmlparser/DocumentUpdateFeedOperation.java @@ -2,16 +2,11 @@ package com.yahoo.vespaxmlparser; import com.yahoo.document.DocumentUpdate; -import com.yahoo.document.TestAndSetCondition; public class DocumentUpdateFeedOperation extends ConditionalFeedOperation { private final DocumentUpdate update; public DocumentUpdateFeedOperation(DocumentUpdate update) { - super(Type.UPDATE); - this.update = update; - } - public DocumentUpdateFeedOperation(DocumentUpdate update, TestAndSetCondition condition) { - super(Type.UPDATE, condition); + super(Type.UPDATE, update.getCondition()); this.update = update; } diff --git a/document/src/main/java/com/yahoo/vespaxmlparser/FeedOperation.java b/document/src/main/java/com/yahoo/vespaxmlparser/FeedOperation.java index 69d851b09bc..a77e752f79b 100644 --- a/document/src/main/java/com/yahoo/vespaxmlparser/FeedOperation.java +++ b/document/src/main/java/com/yahoo/vespaxmlparser/FeedOperation.java @@ -1,8 +1,8 @@ // Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. package com.yahoo.vespaxmlparser; -import com.yahoo.document.Document; -import com.yahoo.document.DocumentId; +import com.yahoo.document.DocumentRemove; +import com.yahoo.document.DocumentPut; import com.yahoo.document.DocumentUpdate; import com.yahoo.document.TestAndSetCondition; @@ -21,9 +21,9 @@ public class FeedOperation { this.type = type; } - public Document getDocument() { return null; } + public DocumentPut getDocumentPut() { return null; } public DocumentUpdate getDocumentUpdate() { return null; } - public DocumentId getRemove() { return null; } + public DocumentRemove getDocumentRemove() { return null; } public TestAndSetCondition getCondition() { return TestAndSetCondition.NOT_PRESENT_CONDITION; @@ -32,8 +32,8 @@ public class FeedOperation { public String toString() { return "Operation{" + "type=" + getType() + - ", doc=" + getDocument() + - ", remove=" + getRemove() + + ", doc=" + getDocumentPut() + + ", remove=" + getDocumentRemove() + ", docUpdate=" + getDocumentUpdate() + " testandset=" + getCondition() + '}'; diff --git a/document/src/main/java/com/yahoo/vespaxmlparser/RemoveFeedOperation.java b/document/src/main/java/com/yahoo/vespaxmlparser/RemoveFeedOperation.java index 86bd4632905..6c9c87feef4 100644 --- a/document/src/main/java/com/yahoo/vespaxmlparser/RemoveFeedOperation.java +++ b/document/src/main/java/com/yahoo/vespaxmlparser/RemoveFeedOperation.java @@ -2,21 +2,18 @@ package com.yahoo.vespaxmlparser; import com.yahoo.document.DocumentId; +import com.yahoo.document.DocumentRemove; import com.yahoo.document.TestAndSetCondition; public class RemoveFeedOperation extends ConditionalFeedOperation { - private final DocumentId documentId; - public RemoveFeedOperation(DocumentId documentId) { - super(Type.REMOVE); - this.documentId = documentId; - } - public RemoveFeedOperation(DocumentId documentId, TestAndSetCondition condition) { - super(Type.REMOVE, condition); - this.documentId = documentId; + private final DocumentRemove remove; + public RemoveFeedOperation(DocumentRemove remove) { + super(Type.REMOVE, remove.getCondition()); + this.remove = remove; } @Override - public DocumentId getRemove() { - return documentId; + public DocumentRemove getDocumentRemove() { + return remove; } } diff --git a/document/src/main/java/com/yahoo/vespaxmlparser/VespaXMLFeedReader.java b/document/src/main/java/com/yahoo/vespaxmlparser/VespaXMLFeedReader.java index 361665a2ef1..85123de349a 100644 --- a/document/src/main/java/com/yahoo/vespaxmlparser/VespaXMLFeedReader.java +++ b/document/src/main/java/com/yahoo/vespaxmlparser/VespaXMLFeedReader.java @@ -3,6 +3,8 @@ package com.yahoo.vespaxmlparser; import com.yahoo.document.Document; import com.yahoo.document.DocumentId; +import com.yahoo.document.DocumentPut; +import com.yahoo.document.DocumentRemove; import com.yahoo.document.DocumentTypeManager; import com.yahoo.document.DocumentUpdate; import com.yahoo.document.TestAndSetCondition; @@ -99,12 +101,14 @@ public class VespaXMLFeedReader extends VespaXMLReader implements FeedReader { if ("document".equals(startTag)) { VespaXMLDocumentReader documentReader = new VespaXMLDocumentReader(reader, docTypeManager); - Document document = new Document(documentReader); - return new DocumentFeedOperation(document, TestAndSetCondition.fromConditionString(documentReader.getCondition())); + DocumentPut put = new DocumentPut(new Document(documentReader)); + put.setCondition(TestAndSetCondition.fromConditionString(documentReader.getCondition())); + return new DocumentFeedOperation(put); } else if ("update".equals(startTag)) { VespaXMLUpdateReader updateReader = new VespaXMLUpdateReader(reader, docTypeManager); DocumentUpdate update = new DocumentUpdate(updateReader); - return new DocumentUpdateFeedOperation(update, TestAndSetCondition.fromConditionString(updateReader.getCondition())); + update.setCondition(TestAndSetCondition.fromConditionString(updateReader.getCondition())); + return new DocumentUpdateFeedOperation(update); } else if ("remove".equals(startTag)) { DocumentId documentId = null; @@ -121,7 +125,9 @@ public class VespaXMLFeedReader extends VespaXMLReader implements FeedReader { if (documentId == null) { throw newDeserializeException("Missing \"documentid\" attribute for remove operation"); } - return new RemoveFeedOperation(documentId, TestAndSetCondition.fromConditionString(condition)); + DocumentRemove remove = new DocumentRemove(documentId); + remove.setCondition(TestAndSetCondition.fromConditionString(condition)); + return new RemoveFeedOperation(remove); } else { throw newDeserializeException("Element \"" + startTag + "\" not allowed in this context"); } -- cgit v1.2.3