From 016e584f0ad5a071e13d75eb8ad5ddb46b8c54f5 Mon Sep 17 00:00:00 2001 From: Arne Juul Date: Tue, 12 Jun 2018 12:50:28 +0200 Subject: use LOG_ABORT not just abort() * abort() has the unfortunate effect that nothing is seen in the log, just an event (which is usually not displayed); so ops people don't see that the program is crashing at all. * LOG_ABORT("message") will log an error with the message (and the file and line) before calling abort(), so it's easy to see what happened. * add or move include and LOG_SETUP lines before LOG_ABORT is used (or included). --- documentapi/src/vespa/documentapi/messagebus/policies/errorpolicy.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'documentapi') diff --git a/documentapi/src/vespa/documentapi/messagebus/policies/errorpolicy.cpp b/documentapi/src/vespa/documentapi/messagebus/policies/errorpolicy.cpp index 1e9911ecf77..7b87e7df834 100644 --- a/documentapi/src/vespa/documentapi/messagebus/policies/errorpolicy.cpp +++ b/documentapi/src/vespa/documentapi/messagebus/policies/errorpolicy.cpp @@ -3,6 +3,8 @@ #include "errorpolicy.h" #include #include +#include +LOG_SETUP(".documentapi.messagebus.policies.error_policy"); namespace documentapi { @@ -19,7 +21,7 @@ ErrorPolicy::select(mbus::RoutingContext &ctx) void ErrorPolicy::merge(mbus::RoutingContext &) { - abort(); + LOG_ABORT("should not be reached"); } } -- cgit v1.2.3