From f6f0e76416325171b4a39585d58af50133fe7372 Mon Sep 17 00:00:00 2001 From: Jon Marius Venstad Date: Wed, 16 Sep 2020 09:31:52 +0200 Subject: Deprecate DocumentAccess.createDefault which uses self subscription --- documentapi/src/main/java/com/yahoo/documentapi/DocumentAccess.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'documentapi') diff --git a/documentapi/src/main/java/com/yahoo/documentapi/DocumentAccess.java b/documentapi/src/main/java/com/yahoo/documentapi/DocumentAccess.java index d6c3d3ce92f..308eafcd596 100644 --- a/documentapi/src/main/java/com/yahoo/documentapi/DocumentAccess.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/DocumentAccess.java @@ -55,8 +55,11 @@ public abstract class DocumentAccess { * while attempting to create such an object, this method will throw an * exception. * + * @deprecated Inject a DocumentManagerConfig and create a MessageBusDocumentAccess from this instead. + * * @return a running document access object with all default configuration */ + @Deprecated(since = "7") public static DocumentAccess createDefault() { return new com.yahoo.documentapi.messagebus.MessageBusDocumentAccess(); } @@ -67,12 +70,11 @@ public abstract class DocumentAccess { * @param params the parameters to use for setup */ protected DocumentAccess(DocumentAccessParams params) { - super(); if (params.documentmanagerConfig().isPresent()) { // our config has been injected into the creator documentTypeManager = new DocumentTypeManager(params.documentmanagerConfig().get()); documentTypeConfigSubscriber = null; } - else { // fallback to old style subscription + else { // fallback to old style subscription — this should be avoided documentTypeManager = new DocumentTypeManager(); documentTypeConfigSubscriber = DocumentTypeManagerConfigurer.configure(documentTypeManager, params.getDocumentManagerConfigId()); } -- cgit v1.2.3