From 821039f699e69ce9c643e47b1273353197383cbf Mon Sep 17 00:00:00 2001 From: Håvard Pettersen Date: Wed, 22 Sep 2021 19:21:10 +0000 Subject: remove hamming test where Java eval result was ignored Java tensor conformance evaluation failures will break global invariants by dropping tests in the output. We need to isolate test evaluation better before we are able to ignore expressions that will not even parse. --- eval/src/apps/tensor_conformance/generate.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'eval/src/apps') diff --git a/eval/src/apps/tensor_conformance/generate.cpp b/eval/src/apps/tensor_conformance/generate.cpp index 4d757f6ebbc..d0767b45224 100644 --- a/eval/src/apps/tensor_conformance/generate.cpp +++ b/eval/src/apps/tensor_conformance/generate.cpp @@ -286,8 +286,9 @@ void generate_join(TestBuilder &dst) { generate_op2_join("min(a,b)", Div16(N()), dst); generate_op2_join("max(a,b)", Div16(N()), dst); generate_op2_join("bit(a,b)", Seq({-128, -43, -1, 0, 85, 127}), Seq({0, 1, 2, 3, 4, 5, 6, 7}), dst); - IgnoreJava ignore_java(dst); - generate_op2_join("hamming(a,b)", Seq({-128, -43, -1, 0, 85, 127}), ignore_java); // TODO: require java + // TODO: add ignored Java test when it can be ignored + // IgnoreJava ignore_java(dst); + // generate_op2_join("hamming(a,b)", Seq({-128, -43, -1, 0, 85, 127}), ignore_java); // TODO: require java // inverted lambda generate_join_expr("join(a,b,f(a,b)(b-a))", Div16(N()), dst); // custom lambda @@ -346,8 +347,9 @@ void generate_merge(TestBuilder &dst) { generate_op2_merge("min(a,b)", Div16(N()), dst); generate_op2_merge("max(a,b)", Div16(N()), dst); generate_op2_merge("bit(a,b)", Seq({-128, -43, -1, 0, 85, 127}), Seq({0, 1, 2, 3, 4, 5, 6, 7}), dst); - IgnoreJava ignore_java(dst); - generate_op2_merge("hamming(a,b)", Seq({-128, -43, -1, 0, 85, 127}), ignore_java); // TODO: require java + // TODO: add ignored Java test when it can be ignored + // IgnoreJava ignore_java(dst); + // generate_op2_merge("hamming(a,b)", Seq({-128, -43, -1, 0, 85, 127}), ignore_java); // TODO: require java // inverted lambda generate_merge_expr("merge(a,b,f(a,b)(b-a))", Div16(N()), dst); // custom lambda -- cgit v1.2.3