From 85198252f778b299fddf4aecdf848e6cba11a733 Mon Sep 17 00:00:00 2001 From: Arne Juul Date: Wed, 10 Mar 2021 12:58:31 +0000 Subject: remove bad comparison * cannot compare with result generated directly for output cell type, because going via the input type is allowed to cause precision loss --- .../tests/instruction/generic_cell_cast/generic_cell_cast_test.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'eval') diff --git a/eval/src/tests/instruction/generic_cell_cast/generic_cell_cast_test.cpp b/eval/src/tests/instruction/generic_cell_cast/generic_cell_cast_test.cpp index 95db66a3b13..6e4ac6fca2b 100644 --- a/eval/src/tests/instruction/generic_cell_cast/generic_cell_cast_test.cpp +++ b/eval/src/tests/instruction/generic_cell_cast/generic_cell_cast_test.cpp @@ -48,12 +48,11 @@ void test_generic_cell_cast_with(const ValueBuilderFactory &factory) { for (CellType in_type: CellTypeUtils::list_types()) { for (CellType out_type: CellTypeUtils::list_types()) { auto lhs = layout.cpy().cells(in_type); - auto gen_expect = layout.cpy().cells(out_type); - if (lhs.bad_scalar() || gen_expect.bad_scalar()) continue; + auto res_check = layout.cpy().cells(out_type); + if (lhs.bad_scalar() || res_check.bad_scalar()) continue; SCOPED_TRACE(fmt("\n===\nLHS: %s\n===\n", lhs.gen().to_string().c_str())); auto expect = ReferenceOperations::cell_cast(lhs, out_type); auto actual = perform_generic_cell_cast(lhs, out_type, factory); - EXPECT_EQ(expect, gen_expect); EXPECT_EQ(actual, expect); } } -- cgit v1.2.3