From f58978baba81c7b9a5154da528fb07333993ebbb Mon Sep 17 00:00:00 2001 From: Bjørn Christian Seime Date: Wed, 2 Dec 2020 14:35:15 +0100 Subject: Specify owner(s) for all flags --- .../src/main/java/com/yahoo/vespa/flags/Flags.java | 103 +++++++++++---------- 1 file changed, 53 insertions(+), 50 deletions(-) (limited to 'flags') diff --git a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java index 44696a6ec92..c44fba20f5d 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java @@ -48,14 +48,14 @@ public class Flags { public static final UnboundBooleanFlag FLEET_CANARY = defineFeatureFlag( "fleet-canary", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "Whether the host is a fleet canary.", "Takes effect on next host admin tick.", HOSTNAME); public static final UnboundListFlag DISABLED_HOST_ADMIN_TASKS = defineListFlag( "disabled-host-admin-tasks", List.of(), String.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("valerijf"), "2020-12-02", "2021-02-01", "List of host-admin task names (as they appear in the log, e.g. root>main>UpgradeTask), or some node-agent " + "functionality (see NodeAgentTask), that should be skipped", "Takes effect on next host admin tick", @@ -63,7 +63,7 @@ public class Flags { public static final UnboundStringFlag DOCKER_VERSION = defineStringFlag( "docker-version", "1.13.1-102.git7f2769b", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "The version of the docker to use of the format VERSION-REL: The YUM package to be installed will be " + "2:docker-VERSION-REL.el7.centos.x86_64 in AWS (and without '.centos' otherwise). " + "If docker-version is not of this format, it must be parseable by YumPackageName::fromString.", @@ -72,7 +72,7 @@ public class Flags { public static final UnboundDoubleFlag CONTAINER_CPU_CAP = defineDoubleFlag( "container-cpu-cap", 0, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("valerijf"), "2020-12-02", "2021-02-01", "Hard limit on how many CPUs a container may use. This value is multiplied by CPU allocated to node, so " + "to cap CPU at 200%, set this to 2, etc.", "Takes effect on next node agent tick. Change is orchestrated, but does NOT require container restart", @@ -80,14 +80,14 @@ public class Flags { public static final UnboundIntFlag REBOOT_INTERVAL_IN_DAYS = defineIntFlag( "reboot-interval-in-days", 30, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "No reboots are scheduled 0x-1x reboot intervals after the previous reboot, while reboot is " + "scheduled evenly distributed in the 1x-2x range (and naturally guaranteed at the 2x boundary).", "Takes effect on next run of NodeRebooter"); public static final UnboundBooleanFlag RETIRE_WITH_PERMANENTLY_DOWN = defineFeatureFlag( "retire-with-permanently-down", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "If enabled, retirement will end with setting the host status to PERMANENTLY_DOWN, " + "instead of ALLOWED_TO_BE_DOWN (old behavior).", "Takes effect on the next run of RetiredExpirer.", @@ -95,7 +95,7 @@ public class Flags { public static final UnboundListFlag PREPROVISION_CAPACITY = defineListFlag( "preprovision-capacity", List.of(), ClusterCapacity.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "Specifies the resources that ought to be immediately available for additional cluster " + "allocations. If the resources are not available, additional hosts will be provisioned. " + "Only applies to dynamically provisioned zones.", @@ -103,150 +103,150 @@ public class Flags { public static final UnboundJacksonFlag SHARED_HOST = defineJacksonFlag( "shared-host", SharedHost.createDisabled(), SharedHost.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "Specifies whether shared hosts can be provisioned, and if so, the advertised " + "node resources of the host, the maximum number of containers, etc.", "Takes effect on next iteration of DynamicProvisioningMaintainer."); public static final UnboundListFlag INACTIVE_MAINTENANCE_JOBS = defineListFlag( "inactive-maintenance-jobs", List.of(), String.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("mpolden"), "2020-12-02", "2021-02-01", "The list of maintenance jobs that are inactive.", "Takes effect immediately, but any currently running jobs will run until completion."); public static final UnboundDoubleFlag DEFAULT_TERM_WISE_LIMIT = defineDoubleFlag( "default-term-wise-limit", 1.0, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Default limit for when to apply termwise query evaluation", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundStringFlag JVM_GC_OPTIONS = defineStringFlag( "jvm-gc-options", "", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Sets deafult jvm gc options", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundStringFlag FEED_SEQUENCER_TYPE = defineStringFlag( "feed-sequencer-type", "LATENCY", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Selects type of sequenced executor used for feeding, valid values are LATENCY, ADAPTIVE, THROUGHPUT", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundStringFlag RESPONSE_SEQUENCER_TYPE = defineStringFlag( "response-sequencer-type", "ADAPTIVE", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Selects type of sequenced executor used for mbus responses, valid values are LATENCY, ADAPTIVE, THROUGHPUT", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundIntFlag RESPONSE_NUM_THREADS = defineIntFlag( "response-num-threads", 2, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Number of threads used for mbus responses, default is 2, negative number = numcores/4", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag SKIP_COMMUNICATIONMANAGER_THREAD = defineFeatureFlag( "skip-communicatiomanager-thread", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Should we skip the communicationmanager thread", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag SKIP_MBUS_REQUEST_THREAD = defineFeatureFlag( "skip-mbus-request-thread", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Should we skip the mbus request thread", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag SKIP_MBUS_REPLY_THREAD = defineFeatureFlag( "skip-mbus-reply-thread", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Should we skip the mbus reply thread", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag USE_THREE_PHASE_UPDATES = defineFeatureFlag( "use-three-phase-updates", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("vekterli"), "2020-12-02", "2021-02-01", "Whether to enable the use of three-phase updates when bucket replicas are out of sync.", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag USE_DIRECT_STORAGE_API_RPC = defineFeatureFlag( "use-direct-storage-api-rpc", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("geirst"), "2020-12-02", "2021-02-01", "Whether to use direct RPC for Storage API communication between content cluster nodes.", "Takes effect at restart of distributor and content node process", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag USE_FAST_VALUE_TENSOR_IMPLEMENTATION = defineFeatureFlag( "use-fast-value-tensor-implementation", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("geirst"), "2020-12-02", "2021-02-01", "Whether to use FastValueBuilderFactory as the tensor implementation on all content nodes.", "Takes effect at restart of content node process", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag HOST_HARDENING = defineFeatureFlag( "host-hardening", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hakonhall"), "2020-12-02", "2021-02-01", "Whether to enable host hardening Linux baseline.", "Takes effect on next tick or on host-admin restart (may vary where used).", HOSTNAME); public static final UnboundBooleanFlag TCP_ABORT_ON_OVERFLOW = defineFeatureFlag( "tcp-abort-on-overflow", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Whether to set /proc/sys/net/ipv4/tcp_abort_on_overflow to 0 (false) or 1 (true)", "Takes effect on next host-admin tick.", HOSTNAME); public static final UnboundStringFlag ZOOKEEPER_SERVER_VERSION = defineStringFlag( "zookeeper-server-version", "3.5.6", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hmusum"), "2020-12-02", "2021-02-01", "ZooKeeper server version, a jar file zookeeper-server--jar-with-dependencies.jar must exist", "Takes effect on restart of Docker container", NODE_TYPE, APPLICATION_ID, HOSTNAME); public static final UnboundStringFlag TLS_FOR_ZOOKEEPER_CLIENT_SERVER_COMMUNICATION = defineStringFlag( "tls-for-zookeeper-client-server-communication", "OFF", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hmusum"), "2020-12-02", "2021-02-01", "How to setup TLS for ZooKeeper client/server communication. Valid values are OFF, PORT_UNIFICATION, TLS_WITH_PORT_UNIFICATION, TLS_ONLY", "Takes effect on restart of config server", NODE_TYPE, HOSTNAME); public static final UnboundBooleanFlag USE_TLS_FOR_ZOOKEEPER_CLIENT = defineFeatureFlag( "use-tls-for-zookeeper-client", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hmusum"), "2020-12-02", "2021-02-01", "Whether to use TLS for ZooKeeper clients", "Takes effect on restart of process", NODE_TYPE, HOSTNAME); public static final UnboundBooleanFlag VALIDATE_ENDPOINT_CERTIFICATES = defineFeatureFlag( "validate-endpoint-certificates", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Whether endpoint certificates should be validated before use", "Takes effect on the next deployment of the application"); public static final UnboundStringFlag DELETE_UNUSED_ENDPOINT_CERTIFICATES = defineStringFlag( "delete-unused-endpoint-certificates", "disable", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Whether the endpoint certificate maintainer should delete unused certificates in cameo/zk", "Takes effect on next scheduled run of maintainer - set to \"disable\", \"dryrun\" or \"enable\""); public static final UnboundBooleanFlag USE_ALTERNATIVE_ENDPOINT_CERTIFICATE_PROVIDER = defineFeatureFlag( "use-alternative-endpoint-certificate-provider", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Whether to use an alternative CA when provisioning new certificates", "Takes effect only on initial application deployment - not on later certificate refreshes!"); public static final UnboundStringFlag DOCKER_IMAGE_REPO = defineStringFlag( "docker-image-repo", "", - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("valerijf"), "2020-12-02", "2021-02-01", "Override default docker image repo. Docker image version will be Vespa version.", "Takes effect on next deployment from controller", ZONE_ID, APPLICATION_ID); @@ -259,27 +259,27 @@ public class Flags { public static final UnboundBooleanFlag ENDPOINT_CERT_IN_SHARED_ROUTING = defineFeatureFlag( "endpoint-cert-in-shared-routing", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Whether to provision and use endpoint certs for apps in shared routing zones", "Takes effect on next deployment of the application", APPLICATION_ID); public static final UnboundBooleanFlag PROVISION_APPLICATION_ROLES = defineFeatureFlag( "provision-application-roles", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("tokle"), "2020-12-02", "2021-02-01", "Whether application roles should be provisioned", "Takes effect on next deployment (controller)", ZONE_ID); public static final UnboundBooleanFlag APPLICATION_IAM_ROLE = defineFeatureFlag( "application-iam-roles", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("tokle"), "2020-12-02", "2021-02-01", "Allow separate iam roles when provisioning/assigning hosts", "Takes effect immediately on new hosts, on next redeploy for applications", APPLICATION_ID); public static final UnboundBooleanFlag ENABLE_PUBLIC_SIGNUP_FLOW = defineFeatureFlag( "enable-public-signup-flow", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "Show the public signup flow for a user in the console", "takes effect on browser reload of api/user/v1/user", CONSOLE_USER_EMAIL @@ -287,7 +287,7 @@ public class Flags { public static final UnboundBooleanFlag CONTROLLER_PROVISION_LB = defineFeatureFlag( "controller-provision-lb", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("mpolden"), "2020-12-02", "2021-02-01", "Provision load balancer for controller cluster", "Takes effect when controller application is redeployed", ZONE_ID @@ -295,7 +295,7 @@ public class Flags { public static final UnboundIntFlag TENANT_NODE_QUOTA = defineIntFlag( "tenant-node-quota", 5, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("andreer"), "2020-12-02", "2021-02-01", "The number of nodes a tenant is allowed to request per cluster", "Only takes effect on next deployment, if set to a value other than the default for flag!", APPLICATION_ID @@ -303,7 +303,7 @@ public class Flags { public static final UnboundIntFlag TENANT_BUDGET_QUOTA = defineIntFlag( "tenant-budget-quota", -1, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("ogronnesby"), "2020-12-02", "2021-02-01", "The budget in cents/hr a tenant is allowed spend per instance, as calculated by NodeResources", "Only takes effect on next deployment, if set to a value other than the default for flag!", TENANT_ID @@ -311,28 +311,28 @@ public class Flags { public static final UnboundBooleanFlag ONLY_PUBLIC_ACCESS = defineFeatureFlag( "enable-public-only", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("ogronnesby"), "2020-12-02", "2021-02-01", "Only access public hosts from container", "Takes effect on next tick" ); public static final UnboundListFlag OUTBOUND_BLOCKED_IPV4 = defineListFlag( "container-outbound-blocked-ipv4", List.of(), String.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("ogronnesby"), "2020-12-02", "2021-02-01", "List of IPs or CIDRs that are blocked for outbound connections", "Takes effect on next tick" ); public static final UnboundListFlag OUTBOUND_BLOCKED_IPV6 = defineListFlag( "container-outbound-blocked-ipv6", List.of(), String.class, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("ogronnesby"), "2020-12-02", "2021-02-01", "List of IPs or CIDRs that are blocked for outbound connections", "Takes effect on next tick" ); public static final UnboundBooleanFlag HIDE_SHARED_ROUTING_ENDPOINT = defineFeatureFlag( "hide-shared-routing-endpoint", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("tokle"), "2020-12-02", "2021-02-01", "Whether the controller should hide shared routing layer endpoint", "Takes effect immediately", APPLICATION_ID @@ -340,60 +340,63 @@ public class Flags { public static final UnboundBooleanFlag SKIP_MAINTENANCE_DEPLOYMENT = defineFeatureFlag( "node-repository-skip-maintenance-deployment", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hmusum"), "2020-12-02", "2021-02-01", "Whether PeriodicApplicationMaintainer should skip deployment for an application", "Takes effect at next run of maintainer", APPLICATION_ID); public static final UnboundBooleanFlag USE_ACCESS_CONTROL_CLIENT_AUTHENTICATION = defineFeatureFlag( "use-access-control-client-authentication", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("tokle"), "2020-12-02", "2021-02-01", "Whether application container should set up client authentication on default port based on access control element", "Takes effect on next internal redeployment", APPLICATION_ID); public static final UnboundBooleanFlag USE_ASYNC_MESSAGE_HANDLING_ON_SCHEDULE = defineFeatureFlag( "async-message-handling-on-schedule", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Optionally deliver async messages in own thread", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); + public static final UnboundIntFlag CONTENT_NODE_BUCKET_DB_STRIPE_BITS = defineIntFlag( "content-node-bucket-db-stripe-bits", 0, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "Number of bits used for striping the bucket DB in service layer", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); + public static final UnboundIntFlag MERGE_CHUNK_SIZE = defineIntFlag( "merge-chunk-size", 0x400000, - List.of("nobody"), "2020-12-02", "2021-02-01", - "Size of merge buffer in service layer", + List.of("baldersheim"), "2020-12-02", "2021-02-01", + "Size of baldersheim buffer in service layer", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); + public static final UnboundDoubleFlag FEED_CONCURRENCY = defineDoubleFlag( "feed-concurrency", 0.5, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("baldersheim"), "2020-12-02", "2021-02-01", "How much concurrency should be allowed for feed", "Takes effect at redeployment", ZONE_ID, APPLICATION_ID); public static final UnboundBooleanFlag ENABLE_AUTOMATIC_REINDEXING = defineFeatureFlag( "enable-automatic-reindexing", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("bjorncs", "jonmv"), "2020-12-02", "2021-02-01", "Whether to automatically trigger reindexing from config change", "Takes effect on next internal redeployment", APPLICATION_ID); public static final UnboundBooleanFlag USE_POWER_OF_TWO_CHOICES_LOAD_BALANCING = defineFeatureFlag( "use-power-of-two-choices-load-balancing", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("tokle"), "2020-12-02", "2021-02-01", "Whether to use Power of two load balancing algorithm for application", "Takes effect on next internal redeployment", APPLICATION_ID); public static final UnboundBooleanFlag DYNAMIC_RECONFIGURATION_OF_ZOOKEEPER_CLUSTER = defineFeatureFlag( "dynamic-reconfiguration-of-zookeeper-cluster", false, - List.of("nobody"), "2020-12-02", "2021-02-01", + List.of("hmusum"), "2020-12-02", "2021-02-01", "Whether to allow dynamic reconfiguration of zookeeper cluster", "Takes effect on next deployment", APPLICATION_ID); -- cgit v1.2.3