From fd54b4e4b136b05b67b471dca3ca6ce3dd116710 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Sun, 4 Dec 2022 22:42:13 +0100 Subject: Revert collect(Collectors.toList()) --- flags/src/main/java/com/yahoo/vespa/flags/json/FlagData.java | 8 ++++---- .../main/java/com/yahoo/vespa/flags/json/RelationalPredicate.java | 2 +- flags/src/main/java/com/yahoo/vespa/flags/json/Rule.java | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'flags') diff --git a/flags/src/main/java/com/yahoo/vespa/flags/json/FlagData.java b/flags/src/main/java/com/yahoo/vespa/flags/json/FlagData.java index 19837e7dbe1..28dbc588648 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/json/FlagData.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/json/FlagData.java @@ -83,7 +83,7 @@ public class FlagData { wireFlagData.id = id.toString(); if (!rules.isEmpty()) { - wireFlagData.rules = rules.stream().map(Rule::toWire).toList(); + wireFlagData.rules = rules.stream().map(Rule::toWire).collect(Collectors.toList()); } wireFlagData.defaultFetchVector = FetchVectorHelper.toWire(defaultFetchVector); @@ -126,17 +126,17 @@ public class FlagData { public static WireFlagDataList listToWire(List list) { WireFlagDataList wireList = new WireFlagDataList(); - wireList.flags = list.stream().map(FlagData::toWire).toList(); + wireList.flags = list.stream().map(FlagData::toWire).collect(Collectors.toList()); return wireList; } public static List listFromWire(WireFlagDataList wireList) { - return wireList.flags.stream().map(FlagData::fromWire).toList(); + return wireList.flags.stream().map(FlagData::fromWire).collect(Collectors.toList()); } private static List rulesFromWire(List wireRules) { if (wireRules == null) return List.of(); - return wireRules.stream().map(Rule::fromWire).toList(); + return wireRules.stream().map(Rule::fromWire).collect(Collectors.toList()); } /** E.g. verify all RawFlag can be deserialized. */ diff --git a/flags/src/main/java/com/yahoo/vespa/flags/json/RelationalPredicate.java b/flags/src/main/java/com/yahoo/vespa/flags/json/RelationalPredicate.java index 749c0e2f067..8eaf38ed577 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/json/RelationalPredicate.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/json/RelationalPredicate.java @@ -19,7 +19,7 @@ public class RelationalPredicate { // Make sure we try to match e.g. "<=" before "<" as the prefix of predicateString. List operatorsByDecendingLength = Stream.of(RelationalOperator.values()) .sorted(Comparator.comparing(operator -> - operator.toText().length())) - .toList(); + .collect(Collectors.toList()); for (var operator : operatorsByDecendingLength) { if (predicateString.startsWith(operator.toText())) { diff --git a/flags/src/main/java/com/yahoo/vespa/flags/json/Rule.java b/flags/src/main/java/com/yahoo/vespa/flags/json/Rule.java index bddaf8c9e0e..d7cc5b4ddb2 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/json/Rule.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/json/Rule.java @@ -53,7 +53,7 @@ public class Rule { WireRule wireRule = new WireRule(); if (!andConditions.isEmpty()) { - wireRule.andConditions = andConditions.stream().map(Condition::toWire).toList(); + wireRule.andConditions = andConditions.stream().map(Condition::toWire).collect(Collectors.toList()); } wireRule.value = valueToApply.map(RawFlag::asJsonNode).orElse(null); @@ -64,7 +64,7 @@ public class Rule { public static Rule fromWire(WireRule wireRule) { List conditions = wireRule.andConditions == null ? Collections.emptyList() : - wireRule.andConditions.stream().map(Condition::fromWire).toList(); + wireRule.andConditions.stream().map(Condition::fromWire).collect(Collectors.toList()); Optional value = wireRule.value == null ? Optional.empty() : Optional.of(JsonNodeRawFlag.fromJsonNode(wireRule.value)); return new Rule(value, conditions); } -- cgit v1.2.3