From bad739ae3be754bb495b5a3b5830a0c972f8fa39 Mon Sep 17 00:00:00 2001 From: Bjørn Christian Seime Date: Tue, 8 Feb 2022 16:03:06 +0100 Subject: Deprecate method leaking Guice --- jdisc_core/src/test/java/com/yahoo/jdisc/RequestTestCase.java | 6 ------ .../java/com/yahoo/jdisc/core/ContainerSnapshotTestCase.java | 4 ---- .../java/com/yahoo/jdisc/test/NonWorkingRequestTestCase.java | 9 ++++----- 3 files changed, 4 insertions(+), 15 deletions(-) (limited to 'jdisc_core/src/test') diff --git a/jdisc_core/src/test/java/com/yahoo/jdisc/RequestTestCase.java b/jdisc_core/src/test/java/com/yahoo/jdisc/RequestTestCase.java index 987a24fe332..75154dd588e 100644 --- a/jdisc_core/src/test/java/com/yahoo/jdisc/RequestTestCase.java +++ b/jdisc_core/src/test/java/com/yahoo/jdisc/RequestTestCase.java @@ -3,7 +3,6 @@ package com.yahoo.jdisc; import com.google.inject.AbstractModule; import com.google.inject.Guice; -import com.google.inject.Key; import com.yahoo.jdisc.application.BindingMatch; import com.yahoo.jdisc.application.UriPattern; import com.yahoo.jdisc.handler.CompletionHandler; @@ -306,11 +305,6 @@ public class RequestTestCase { return requestHandler; } - @Override - public T getInstance(Key key) { - return Guice.createInjector().getInstance(key); - } - @Override public T getInstance(Class type) { return Guice.createInjector().getInstance(type); diff --git a/jdisc_core/src/test/java/com/yahoo/jdisc/core/ContainerSnapshotTestCase.java b/jdisc_core/src/test/java/com/yahoo/jdisc/core/ContainerSnapshotTestCase.java index 3e6987c8c6f..dc1f3c7609e 100644 --- a/jdisc_core/src/test/java/com/yahoo/jdisc/core/ContainerSnapshotTestCase.java +++ b/jdisc_core/src/test/java/com/yahoo/jdisc/core/ContainerSnapshotTestCase.java @@ -2,8 +2,6 @@ package com.yahoo.jdisc.core; import com.google.inject.AbstractModule; -import com.google.inject.Key; -import com.google.inject.name.Names; import com.yahoo.jdisc.AbstractResource; import com.yahoo.jdisc.Request; import com.yahoo.jdisc.application.BindingMatch; @@ -142,13 +140,11 @@ public class ContainerSnapshotTestCase { @Override protected void configure() { bind(Object.class).toInstance(obj); - bind(String.class).annotatedWith(Names.named("foo")).toInstance("foo"); } }); ActiveContainer active = new ActiveContainer(driver.newContainerBuilder()); ContainerSnapshot snapshot = new ContainerSnapshot(active, null, null, null); assertSame(obj, snapshot.getInstance(Object.class)); - assertEquals("foo", snapshot.getInstance(Key.get(String.class, Names.named("foo")))); snapshot.release(); assertTrue(driver.close()); } diff --git a/jdisc_core/src/test/java/com/yahoo/jdisc/test/NonWorkingRequestTestCase.java b/jdisc_core/src/test/java/com/yahoo/jdisc/test/NonWorkingRequestTestCase.java index ac55334308c..b0d67102a12 100644 --- a/jdisc_core/src/test/java/com/yahoo/jdisc/test/NonWorkingRequestTestCase.java +++ b/jdisc_core/src/test/java/com/yahoo/jdisc/test/NonWorkingRequestTestCase.java @@ -2,13 +2,11 @@ package com.yahoo.jdisc.test; import com.google.inject.AbstractModule; -import com.google.inject.Key; -import com.google.inject.name.Names; import com.yahoo.jdisc.Request; import org.junit.Test; -import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertSame; /** @@ -23,13 +21,14 @@ public class NonWorkingRequestTestCase { @Test public void requireThatGuiceModulesAreInjected() { + Object obj = new Object(); Request request = NonWorkingRequest.newInstance("scheme://host/path", new AbstractModule() { @Override protected void configure() { - bind(String.class).annotatedWith(Names.named("foo")).toInstance("bar"); + bind(Object.class).toInstance(obj); } }); - assertEquals("bar", request.container().getInstance(Key.get(String.class, Names.named("foo")))); + assertSame(obj, request.container().getInstance(Object.class)); } } -- cgit v1.2.3