From 452f6ffb06b55e646c93eef1d5dbce673ce68f91 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Thu, 11 May 2023 10:59:25 +0200 Subject: Use assertEquals instead of assertTrue/False and also dump state prior to lookup. --- jrt/tests/com/yahoo/jrt/SlobrokTest.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) (limited to 'jrt') diff --git a/jrt/tests/com/yahoo/jrt/SlobrokTest.java b/jrt/tests/com/yahoo/jrt/SlobrokTest.java index a7ba768b1e9..449fbb2a8d8 100644 --- a/jrt/tests/com/yahoo/jrt/SlobrokTest.java +++ b/jrt/tests/com/yahoo/jrt/SlobrokTest.java @@ -13,7 +13,9 @@ import com.yahoo.jrt.slobrok.server.Slobrok; import org.junit.After; import org.junit.Before; +import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotEquals; import static org.junit.Assert.assertTrue; public class SlobrokTest { @@ -110,17 +112,18 @@ public class SlobrokTest { assertTrue(mirror.ready()); assertTrue(mirror.updates() > 0); + mirror.dumpState(); List oneArr = mirror.lookup("*/*/*"); mirror.dumpState(); - assertTrue(oneArr.size() == 1); + assertEquals(1, oneArr.size()); Mirror.Entry one = oneArr.get(0); - assertTrue(one.equals(new Mirror.Entry(wantName, mySpec))); - assertFalse(one.equals(new Mirror.Entry("B/x/w", mySpec))); - assertFalse(one.equals(new Mirror.Entry(wantName, "foo:99"))); - assertFalse(one.equals(null)); - assertFalse(one.equals(register)); - assertTrue(one.getName().equals(wantName)); - assertTrue(one.getSpecString().equals(mySpec)); + assertEquals(one, new Entry(wantName, mySpec)); + assertNotEquals(one, new Entry("B/x/w", mySpec)); + assertNotEquals(one, new Entry(wantName, "foo:99")); + assertNotEquals(one, null); + assertNotEquals(one, register); + assertEquals(one.getName(), wantName); + assertEquals(one.getSpecString(), mySpec); register.registerName("B/x"); check("B/x", new SpecList().add("B/x", mySpec)); -- cgit v1.2.3