From 755b6913407613821fb47fac95592930612add4b Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Mon, 12 Sep 2016 22:16:01 +0000 Subject: Reduce boost::noncopyable exposure. --- memfilepersistence/src/vespa/memfilepersistence/mapper/buffer.h | 5 +++-- .../src/vespa/memfilepersistence/mapper/bufferedfilewriter.h | 5 +++-- .../src/vespa/memfilepersistence/memfile/memfilecache.h | 4 +++- .../src/vespa/memfilepersistence/spi/operationhandler.h | 6 +++--- 4 files changed, 12 insertions(+), 8 deletions(-) (limited to 'memfilepersistence') diff --git a/memfilepersistence/src/vespa/memfilepersistence/mapper/buffer.h b/memfilepersistence/src/vespa/memfilepersistence/mapper/buffer.h index 2484209d23e..d097a078af9 100644 --- a/memfilepersistence/src/vespa/memfilepersistence/mapper/buffer.h +++ b/memfilepersistence/src/vespa/memfilepersistence/mapper/buffer.h @@ -11,14 +11,13 @@ #pragma once -#include #include #include namespace storage { namespace memfile { -class Buffer : boost::noncopyable // Ensure no accidental copying of a buffer +class Buffer { // Use AutoAlloc to transparently use mmap for large buffers. // It is crucial that any backing buffer type returns an address that is @@ -33,6 +32,8 @@ class Buffer : boost::noncopyable // Ensure no accidental copying of a buffer public: typedef vespalib::LinkedPtr LP; + Buffer(const Buffer &) = delete; + Buffer & operator = (const Buffer &) = delete; Buffer(size_t size); /** diff --git a/memfilepersistence/src/vespa/memfilepersistence/mapper/bufferedfilewriter.h b/memfilepersistence/src/vespa/memfilepersistence/mapper/bufferedfilewriter.h index e1101d94b58..67cdd2208a0 100644 --- a/memfilepersistence/src/vespa/memfilepersistence/mapper/bufferedfilewriter.h +++ b/memfilepersistence/src/vespa/memfilepersistence/mapper/bufferedfilewriter.h @@ -16,7 +16,6 @@ #pragma once -#include #include #include @@ -28,7 +27,7 @@ namespace storage { namespace memfile { -class BufferedFileWriter : public boost::noncopyable { +class BufferedFileWriter { public: struct Cache { virtual ~Cache() {} @@ -55,6 +54,8 @@ private: bool _writing; public: + BufferedFileWriter(const BufferedFileWriter &) = delete; + BufferedFileWriter & operator = (const BufferedFileWriter &) = delete; /** * Create a new buffered file writer. * diff --git a/memfilepersistence/src/vespa/memfilepersistence/memfile/memfilecache.h b/memfilepersistence/src/vespa/memfilepersistence/memfile/memfilecache.h index cc25bd5f7a8..e4417fb6e0f 100644 --- a/memfilepersistence/src/vespa/memfilepersistence/memfile/memfilecache.h +++ b/memfilepersistence/src/vespa/memfilepersistence/memfile/memfilecache.h @@ -51,7 +51,7 @@ public: {} }; private: - class Entry : boost::noncopyable { + class Entry { public: typedef vespalib::LinkedPtr LP; @@ -61,6 +61,8 @@ private: bool _inUse; bool _returnToCacheWhenFinished; + Entry(const Entry &) = delete; + Entry & operator = (const Entry &) = delete; Entry(FileSpecification& file, Environment& env, bool returnToCacheWhenFinished = true) : _file(file, env), _env(env), _inUse(true), diff --git a/memfilepersistence/src/vespa/memfilepersistence/spi/operationhandler.h b/memfilepersistence/src/vespa/memfilepersistence/spi/operationhandler.h index 9a2700c4209..fad723de4aa 100644 --- a/memfilepersistence/src/vespa/memfilepersistence/spi/operationhandler.h +++ b/memfilepersistence/src/vespa/memfilepersistence/spi/operationhandler.h @@ -10,7 +10,6 @@ */ #pragma once -#include #include #include #include @@ -25,8 +24,7 @@ namespace storage { namespace memfile { -class OperationHandler : protected Types, - private boost::noncopyable +class OperationHandler : protected Types { protected: Environment& _env; @@ -34,6 +32,8 @@ protected: public: typedef std::unique_ptr UP; + OperationHandler(const OperationHandler &) = delete; + OperationHandler & operator = (const OperationHandler &) = delete; OperationHandler(Environment&); virtual ~OperationHandler() {} -- cgit v1.2.3