From 3cd7be25c87fca3e558c6c793fb7279762a4a7d7 Mon Sep 17 00:00:00 2001
From: Henning Baldersheim <balder@yahoo-inc.com>
Date: Wed, 25 Mar 2020 20:54:27 +0000
Subject: Use a well named helper method for readability.

---
 .../src/main/java/com/yahoo/messagebus/network/rpc/RPCNetwork.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'messagebus/src')

diff --git a/messagebus/src/main/java/com/yahoo/messagebus/network/rpc/RPCNetwork.java b/messagebus/src/main/java/com/yahoo/messagebus/network/rpc/RPCNetwork.java
index 602c33bd6f4..554977d7eb1 100644
--- a/messagebus/src/main/java/com/yahoo/messagebus/network/rpc/RPCNetwork.java
+++ b/messagebus/src/main/java/com/yahoo/messagebus/network/rpc/RPCNetwork.java
@@ -67,10 +67,15 @@ public class RPCNetwork implements Network, MethodHandler {
             new ThreadPoolExecutor(getNumThreads(), getNumThreads(), 0L, TimeUnit.SECONDS,
                                    new SynchronousQueue<>(false),
                                    ThreadFactoryFactory.getDaemonThreadFactory("mbus.net"), new ThreadPoolExecutor.CallerRunsPolicy());
+
     private static int getNumThreads() {
         return Math.max(2, Runtime.getRuntime().availableProcessors()/2);
     }
 
+    private static boolean shouldEnableTcpNodelay(RPCNetworkParams.Optimization optimization) {
+        return optimization == RPCNetworkParams.Optimization.LATENCY;
+    }
+
     /**
      * Create an RPCNetwork. The servicePrefix is combined with session names to create service names. If the service
      * prefix is 'a/b' and the session name is 'c', the resulting service name that identifies the session on the
@@ -82,7 +87,7 @@ public class RPCNetwork implements Network, MethodHandler {
     public RPCNetwork(RPCNetworkParams params, SlobrokConfigSubscriber slobrokConfig) {
         this.slobroksConfig = slobrokConfig;
         identity = params.getIdentity();
-        orb = new Supervisor(new Transport(params.getNumNetworkThreads(), params.getOptimization() == RPCNetworkParams.Optimization.LATENCY));
+        orb = new Supervisor(new Transport(params.getNumNetworkThreads(), shouldEnableTcpNodelay(params.getOptimization())));
         orb.setMaxInputBufferSize(params.getMaxInputBufferSize());
         orb.setMaxOutputBufferSize(params.getMaxOutputBufferSize());
         targetPool = new RPCTargetPool(params.getConnectionExpireSecs(), params.getNumTargetsPerSpec());
-- 
cgit v1.2.3