From 3abdb35128ce98f2dd0cf2dfeb36494cf8a60687 Mon Sep 17 00:00:00 2001 From: Jon Marius Venstad Date: Thu, 3 Dec 2020 15:45:57 +0100 Subject: Apply suggestions from code review --- .../src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'messagebus') diff --git a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java index 5a64ec5f929..ab09c9f5720 100644 --- a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java +++ b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java @@ -10,7 +10,7 @@ import java.util.logging.Logger; * This is an implementation of the {@link ThrottlePolicy} that offers dynamic limits to the number of pending messages a * {@link SourceSession} is allowed to have. Pending means the number of sent messages that have not been replied to yet. *

- * The algorithm works by increasing the number of messages allowed to be pending, the winidow size, until + * The algorithm works by increasing the number of messages allowed to be pending, the window size, until * this no longer increases throughput. At this point, the algorithm is driven by synthetic attraction towards latencies * which satisfy log10(1 / latency) % 1 = e, for some constant 0 < e < 1. Weird? Most certainly! *

@@ -148,7 +148,6 @@ public class DynamicThrottlePolicy extends StaticThrottlePolicy { period *= 0.1; } double efficiency = throughput * period / windowSize; // "efficiency" is a strange name. This is where on the level it is. - if (Math.random() < 1e-2) System.err.println(efficiency); if (efficiency < efficiencyThreshold) { windowSize = Math.min(windowSize * windowSizeBackOff, windowSize - decrementFactor * windowSizeIncrement); localMaxThroughput = 0; -- cgit v1.2.3