From 5aa228307c58ebafd32155d8ac7a0729d58bb874 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Wed, 15 Dec 2021 18:31:13 +0100 Subject: Unify on Map.of/copyOf --- .../src/main/java/ai/vespa/metricsproxy/metric/Metric.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/Metric.java') diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/Metric.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/Metric.java index a9e6e8e6e3c..9265e8ef1e5 100644 --- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/Metric.java +++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/Metric.java @@ -5,8 +5,6 @@ import ai.vespa.metricsproxy.metric.model.ConsumerId; import ai.vespa.metricsproxy.metric.model.DimensionId; import ai.vespa.metricsproxy.metric.model.MetricId; -import java.util.Collections; -import java.util.LinkedHashMap; import java.util.Map; import java.util.Objects; import java.util.Set; @@ -34,12 +32,12 @@ public class Metric { this.time = time; this.value = value; this.name = name; - this.dimensions = dimensions; + this.dimensions = Map.copyOf(dimensions); this.description = description; } public Metric(MetricId name, Number value, long timestamp) { - this(name, value, timestamp, Collections.emptyMap(), ""); + this(name, value, timestamp, Map.of(), ""); } public Metric(MetricId name, Number value) { @@ -47,7 +45,7 @@ public class Metric { } public void setDimensions(Map dimensions) { - this.dimensions = dimensions; + this.dimensions = Map.copyOf(dimensions); } /** @@ -104,7 +102,7 @@ public class Metric { @Override public Metric clone() { - return new Metric(name, value, time, new LinkedHashMap<>(dimensions), getDescription()); + return new Metric(name, value, time, dimensions, getDescription()); } @Override -- cgit v1.2.3