From 6c0ed461c65bbaa90a208049031e9eef33fe6c6a Mon Sep 17 00:00:00 2001 From: gjoranv Date: Mon, 26 Aug 2019 12:00:10 +0200 Subject: Add missing test for invalid path --- .../test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'metrics-proxy') diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java index 66220464e3e..ab0c6c7e6a6 100644 --- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java +++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java @@ -113,7 +113,7 @@ public class MetricsHandlerTest { @Ignore @Test - public void visually_inspect_values_response() throws Exception{ + public void visually_inspect_values_response() throws Exception { String response = testDriver.sendRequest(VALUES_URI).readAll(); ObjectMapper mapper = createObjectMapper(); var jsonModel = mapper.readValue(response, GenericJsonModel.class); @@ -199,6 +199,13 @@ public class MetricsHandlerTest { assertEquals("custom-val", dummy1Metrics.dimensions.get("consumer-dim")); } + @Test + public void invalid_path_yields_error_response() throws Exception { + String response = testDriver.sendRequest(V1_URI + "/invalid").readAll(); + JSONObject root = new JSONObject(response); + assertTrue(root.has("error")); + } + private void assertDownServiceHealth(String consumer) { GenericJsonModel jsonModel = getResponseAsJsonModel(consumer); -- cgit v1.2.3