From 1dc8fa3c988576ee2ad8d78a83df8afa0f5fa736 Mon Sep 17 00:00:00 2001 From: Håkon Hallingstad Date: Mon, 14 Sep 2020 16:50:34 +0200 Subject: Document public method instead --- .../vespa/hosted/node/admin/task/util/process/CommandLine.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'node-admin') diff --git a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/task/util/process/CommandLine.java b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/task/util/process/CommandLine.java index 95b76c4b93a..e00c1dabf0f 100644 --- a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/task/util/process/CommandLine.java +++ b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/task/util/process/CommandLine.java @@ -243,6 +243,10 @@ public class CommandLine { return this; } + /** + * WARNING: This will leave the child as a zombie process until this process dies. + * I.e. only use this just before or a limited number of times per host admin restart. + */ public CommandLine doNotWaitForTermination() { this.waitForTermination = false; return this; @@ -263,8 +267,6 @@ public class CommandLine { private CommandResult doExecute() { try (ChildProcess2 child = processFactory.spawn(this)) { if (!waitForTermination) { - // WARNING: This will leave the child as a zombie process until this process dies. - // I.e. only use this just before or a limited number of times per host admin restart. return new CommandResult(this, 0, ""); } -- cgit v1.2.3