From 6e701db122b7206f0e535300fab25847dfab9828 Mon Sep 17 00:00:00 2001
From: Martin Polden <mpolden@mpolden.no>
Date: Wed, 1 Dec 2021 13:34:52 +0100
Subject: Put node ID in the ID field

---
 .../java/com/yahoo/vespa/hosted/provision/restapi/NodesResponse.java  | 4 ++--
 .../java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java | 2 +-
 .../java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json | 2 +-
 .../java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/controller1.json   | 2 +-
 .../vespa/hosted/provision/restapi/responses/docker-container1.json   | 2 +-
 .../provision/restapi/responses/docker-node1-os-upgrade-complete.json | 2 +-
 .../hosted/provision/restapi/responses/docker-node1-reports-2.json    | 2 +-
 .../hosted/provision/restapi/responses/docker-node1-reports-3.json    | 2 +-
 .../hosted/provision/restapi/responses/docker-node1-reports-4.json    | 2 +-
 .../hosted/provision/restapi/responses/docker-node1-reports.json      | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/docker-node1.json  | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/docker-node2.json  | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/docker-node3.json  | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/docker-node4.json  | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/docker-node5.json  | 2 +-
 .../provision/restapi/responses/dockerhost1-with-firmware-data.json   | 2 +-
 .../yahoo/vespa/hosted/provision/restapi/responses/dockerhost6.json   | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node1.json     | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node10.json    | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node13.json    | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node14.json    | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node2.json     | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node3.json     | 2 +-
 .../vespa/hosted/provision/restapi/responses/node4-after-changes.json | 4 ++--
 .../hosted/provision/restapi/responses/node4-with-hostnames.json      | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node4.json     | 2 +-
 .../vespa/hosted/provision/restapi/responses/node5-after-changes.json | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node5.json     | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node55.json    | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node6.json     | 2 +-
 .../com/yahoo/vespa/hosted/provision/restapi/responses/node7.json     | 2 +-
 32 files changed, 34 insertions(+), 34 deletions(-)

(limited to 'node-repository')

diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesResponse.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesResponse.java
index b7b334aaba4..9d46d87665e 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesResponse.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesResponse.java
@@ -121,14 +121,14 @@ class NodesResponse extends SlimeJsonResponse {
 
         object.setString("url", nodeParentUrl + node.hostname());
         if ( ! allFields) return;
-        object.setString("id", node.hostname());
+        object.setString("id", node.id());
         object.setString("state", NodeSerializer.toString(node.state()));
         object.setString("type", NodeSerializer.toString(node.type()));
         object.setString("hostname", node.hostname());
         if (node.parentHostname().isPresent()) {
             object.setString("parentHostname", node.parentHostname().get());
         }
-        object.setString("openStackId", node.id());
+        object.setString("openStackId", node.id()); // TODO(mpolden): Remove this when all clients use "id"
         object.setString("flavor", node.flavor().name());
         node.reservedTo().ifPresent(reservedTo -> object.setString("reservedTo", reservedTo.value()));
         node.exclusiveToApplicationId().ifPresent(applicationId -> object.setString("exclusiveTo", applicationId.serializedForm()));
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java
index cb0bb7c1ac3..fb5bfbfe66e 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java
@@ -198,7 +198,7 @@ public class NodesV2ApiTest {
                         Utf8.toBytes("{\"currentVespaVersion\": \"6.43.0\",\"currentDockerImage\": \"docker-registry.domain.tld:8080/dist/vespa:6.45.0\"}"), Request.Method.PATCH),
                         "{\"message\":\"Updated host4.yahoo.com\"}");
         assertResponse(new Request("http://localhost:8080/nodes/v2/node/host4.yahoo.com",
-                        Utf8.toBytes("{\"openStackId\": \"patched-openstackid\"}"), Request.Method.PATCH),
+                        Utf8.toBytes("{\"openStackId\": \"patched-id\"}"), Request.Method.PATCH),
                 "{\"message\":\"Updated host4.yahoo.com\"}");
         assertResponse(new Request("http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
                                    Utf8.toBytes("{\"modelName\": \"foo\"}"), Request.Method.PATCH),
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json
index fb2b32fac20..1bb3b1d2bf6 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/cfg1.yahoo.com",
-  "id": "cfg1.yahoo.com",
+  "id": "cfg1",
   "state": "ready",
   "type": "config",
   "hostname": "cfg1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json
index eccde886d7e..311d2e690e8 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/cfg2.yahoo.com",
-  "id": "cfg2.yahoo.com",
+  "id": "cfg2",
   "state": "ready",
   "type": "config",
   "hostname": "cfg2.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/controller1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/controller1.json
index 1631e46fc32..9c0c24706f7 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/controller1.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/controller1.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/controller1.yahoo.com",
-  "id": "controller1.yahoo.com",
+  "id": "fake-controller1.yahoo.com",
   "state": "provisioned",
   "type": "controller",
   "hostname": "controller1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-container1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-container1.json
index 33b7a91fc61..7e90758ec22 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-container1.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-container1.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/test-node-pool-102-2",
-  "id": "test-node-pool-102-2",
+  "id": "fake-test-node-pool-102-2",
   "state": "active",
   "type": "tenant",
   "hostname": "test-node-pool-102-2",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-os-upgrade-complete.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-os-upgrade-complete.json
index ec46755b5ac..4787084c13b 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-os-upgrade-complete.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-os-upgrade-complete.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-2.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-2.json
index c44b172633d..f57387f2bc3 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-2.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-2.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-3.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-3.json
index df745729288..6bf718d77e2 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-3.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-3.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-4.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-4.json
index f6ff292c830..ffb1fde21ec 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-4.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports-4.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports.json
index 335a95f47f5..9aa6e5f2157 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1-reports.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1.json
index 4b7eecdfc26..270924ff94f 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node1.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node2.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node2.json
index e0a7448c111..f503511f7e7 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node2.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node2.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost2.yahoo.com",
-  "id": "dockerhost2.yahoo.com",
+  "id": "dockerhost2",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost2.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node3.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node3.json
index 21f3a54311f..48a9423ebbb 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node3.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node3.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost3.yahoo.com",
-  "id": "dockerhost3.yahoo.com",
+  "id": "dockerhost3",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost3.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node4.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node4.json
index 789b0580357..5d5e8de259b 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node4.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node4.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost4.yahoo.com",
-  "id": "dockerhost4.yahoo.com",
+  "id": "dockerhost4",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost4.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node5.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node5.json
index 35ec6fc0273..71f86ec62f8 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node5.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/docker-node5.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost5.yahoo.com",
-  "id": "dockerhost5.yahoo.com",
+  "id": "dockerhost5",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost5.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost1-with-firmware-data.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost1-with-firmware-data.json
index 498780a2eba..814a3723b04 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost1-with-firmware-data.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost1-with-firmware-data.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost1.yahoo.com",
-  "id": "dockerhost1.yahoo.com",
+  "id": "dockerhost1",
   "state": "active",
   "type": "host",
   "hostname": "dockerhost1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost6.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost6.json
index 1ba16743e25..f80130584f9 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost6.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/dockerhost6.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/dockerhost6.yahoo.com",
-  "id": "dockerhost6.yahoo.com",
+  "id": "dockerhost6",
   "state": "deprovisioned",
   "type": "host",
   "hostname": "dockerhost6.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node1.json
index a35e8aa638b..a93c3bf4811 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node1.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node1.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host1.yahoo.com",
-  "id": "host1.yahoo.com",
+  "id": "node1",
   "state": "active",
   "type": "tenant",
   "hostname": "host1.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node10.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node10.json
index 5d98c75f346..75d9ea4dd4c 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node10.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node10.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host10.yahoo.com",
-  "id": "host10.yahoo.com",
+  "id": "node10",
   "state": "active",
   "type": "tenant",
   "hostname": "host10.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json
index 477a87124e7..1b0fb7d8af9 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host13.yahoo.com",
-  "id": "host13.yahoo.com",
+  "id": "node13",
   "state": "active",
   "type": "tenant",
   "hostname": "host13.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json
index fd533b6372c..32c74ae4dad 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host14.yahoo.com",
-  "id": "host14.yahoo.com",
+  "id": "node14",
   "state": "active",
   "type": "tenant",
   "hostname": "host14.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node2.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node2.json
index e288aaccc28..6f18f0e8204 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node2.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node2.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host2.yahoo.com",
-  "id": "host2.yahoo.com",
+  "id": "node2",
   "state": "active",
   "type": "tenant",
   "hostname": "host2.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node3.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node3.json
index ac3e9ef96b0..69a376d6dd2 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node3.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node3.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host3.yahoo.com",
-  "id": "host3.yahoo.com",
+  "id": "node3",
   "state": "ready",
   "type": "tenant",
   "hostname": "host3.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-after-changes.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-after-changes.json
index 7770227f5f8..db14c5de809 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-after-changes.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-after-changes.json
@@ -1,11 +1,11 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host4.yahoo.com",
-  "id": "host4.yahoo.com",
+  "id": "patched-id",
   "state": "active",
   "type": "tenant",
   "hostname": "host4.yahoo.com",
   "parentHostname": "parent.yahoo.com",
-  "openStackId": "patched-openstackid",
+  "openStackId": "patched-id",
   "flavor": "d-2-8-100",
   "cpuCores": 2.0,
   "resources":{"vcpu":2.0,"memoryGb":8.0,"diskGb":100.0,"bandwidthGbps":1.0,"diskSpeed":"fast","storageType":"remote"},
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-with-hostnames.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-with-hostnames.json
index 165e2480340..708b30b8efb 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-with-hostnames.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4-with-hostnames.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host4.yahoo.com",
-  "id": "host4.yahoo.com",
+  "id": "node4",
   "state": "active",
   "type": "tenant",
   "hostname": "host4.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4.json
index ceb9d88763f..32bb7f781ac 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node4.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host4.yahoo.com",
-  "id": "host4.yahoo.com",
+  "id": "node4",
   "state": "active",
   "type": "tenant",
   "hostname": "host4.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5-after-changes.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5-after-changes.json
index 62ecb313588..3b3f30a471e 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5-after-changes.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5-after-changes.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host5.yahoo.com",
-  "id": "host5.yahoo.com",
+  "id": "node5",
   "state": "failed",
   "type": "tenant",
   "hostname": "host5.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5.json
index 55c16c23a0a..d145b3ba0dc 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node5.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host5.yahoo.com",
-  "id": "host5.yahoo.com",
+  "id": "node5",
   "state": "failed",
   "type": "tenant",
   "hostname": "host5.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node55.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node55.json
index 2ac665bf742..fcefb974327 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node55.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node55.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host55.yahoo.com",
-  "id": "host55.yahoo.com",
+  "id": "node55",
   "state": "parked",
   "type": "tenant",
   "hostname": "host55.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node6.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node6.json
index 1e64c8a8edd..d91fbfa4e75 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node6.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node6.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host6.yahoo.com",
-  "id": "host6.yahoo.com",
+  "id": "node6",
   "state": "active",
   "type": "tenant",
   "hostname": "host6.yahoo.com",
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node7.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node7.json
index 051325612d6..f90d9544b50 100644
--- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node7.json
+++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node7.json
@@ -1,6 +1,6 @@
 {
   "url": "http://localhost:8080/nodes/v2/node/host7.yahoo.com",
-  "id": "host7.yahoo.com",
+  "id": "node7",
   "state": "provisioned",
   "type": "tenant",
   "hostname": "host7.yahoo.com",
-- 
cgit v1.2.3