From 65c857688005ac042809d034a27c9eab586eb4d3 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Wed, 8 Dec 2021 14:01:54 +0000 Subject: - Add class comments. - Unify info logging. - Demote some info logging to debug. --- .../searchcore/proton/docsummary/summarycompacttarget.h | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'searchcore') diff --git a/searchcore/src/vespa/searchcore/proton/docsummary/summarycompacttarget.h b/searchcore/src/vespa/searchcore/proton/docsummary/summarycompacttarget.h index 529aa3b816e..083f763d8e6 100644 --- a/searchcore/src/vespa/searchcore/proton/docsummary/summarycompacttarget.h +++ b/searchcore/src/vespa/searchcore/proton/docsummary/summarycompacttarget.h @@ -32,11 +32,14 @@ private: virtual size_t getBloat(const IDocumentStore & docStore) const = 0; virtual Task::UP create(IDocumentStore & docStore, FlushStats & stats, SerialNum currSerial) = 0; - vespalib::Executor &_summaryService; - IDocumentStore & _docStore; - FlushStats _lastStats; + vespalib::Executor &_summaryService; + IDocumentStore & _docStore; + FlushStats _lastStats; }; +/** + * Implements target to compact away removed documents. Wasted disk space is cost factor used for prioritizing. + */ class SummaryCompactBloatTarget : public SummaryGCTarget { private: size_t getBloat(const search::IDocumentStore & docStore) const override; @@ -45,6 +48,10 @@ public: SummaryCompactBloatTarget(vespalib::Executor & summaryService, IDocumentStore & docStore); }; +/** + * Target to ensure bucket spread is kept low. The cost is reported as a potential gain in disk space as + * we do not have a concept for bucket spread. + */ class SummaryCompactSpreadTarget : public SummaryGCTarget { private: size_t getBloat(const search::IDocumentStore & docStore) const override; -- cgit v1.2.3