From 4080369f2b07de530c859d7d9f0935afdc4f7eb4 Mon Sep 17 00:00:00 2001
From: Henning Baldersheim <balder@yahoo-inc.com>
Date: Tue, 14 Nov 2023 19:35:51 +0000
Subject: Only allow use of bitvector if it is a filter

---
 .../src/tests/attribute/bitvector/bitvector_test.cpp | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'searchlib/src/tests/attribute/bitvector/bitvector_test.cpp')

diff --git a/searchlib/src/tests/attribute/bitvector/bitvector_test.cpp b/searchlib/src/tests/attribute/bitvector/bitvector_test.cpp
index 63c0b784018..dfea4901180 100644
--- a/searchlib/src/tests/attribute/bitvector/bitvector_test.cpp
+++ b/searchlib/src/tests/attribute/bitvector/bitvector_test.cpp
@@ -43,9 +43,8 @@ struct BitVectorTest
 {
     using AttributePtr = AttributeVector::SP;
 
-    BitVectorTest() { }
-
-    ~BitVectorTest() { }
+    BitVectorTest();
+    ~BitVectorTest();
 
     template <typename VectorType>
     VectorType & as(AttributePtr &v);
@@ -102,6 +101,9 @@ struct BitVectorTest
     test(BasicType bt, CollectionType ct, const vespalib::string &pref);
 };
 
+BitVectorTest::BitVectorTest() = default;
+BitVectorTest::~BitVectorTest() = default;
+
 
 template <typename VectorType>
 VectorType &
@@ -427,16 +429,14 @@ BitVectorTest::test(BasicType bt, CollectionType ct, const vespalib::string &pre
 
     SearchContextPtr sc = getSearch<VectorType>(tv, true);
     checkSearch(v, std::move(sc), 2, 1022, 205, !fastSearch && !filter, true);
-    sc = getSearch<VectorType>(tv, false);
+    sc = getSearch<VectorType>(tv, filter);
     checkSearch(v, std::move(sc), 2, 1022, 205, !filter, true);
     const search::IDocumentWeightAttribute *dwa = v->asDocumentWeightAttribute();
     if (dwa != nullptr) {
-        search::IDocumentWeightAttribute::LookupResult lres = 
-            dwa->lookup(getSearchStr<VectorType>(), dwa->get_dictionary_snapshot());
+        auto lres = dwa->lookup(getSearchStr<VectorType>(), dwa->get_dictionary_snapshot());
         using DWSI = search::queryeval::DocumentWeightSearchIterator;
-        using SI = search::queryeval::SearchIterator;
         TermFieldMatchData md;
-        SI::UP dwsi(new DWSI(md, *dwa, lres));
+        auto dwsi = std::make_unique<DWSI>(md, *dwa, lres);
         if (!filter) {
             TEST_DO(checkSearch(v, std::move(dwsi), md, 2, 1022, 205, !filter, true));
         } else {
@@ -445,13 +445,13 @@ BitVectorTest::test(BasicType bt, CollectionType ct, const vespalib::string &pre
         }
     }
     populate(tv, 2, 973, false);
-    sc = getSearch<VectorType>(tv, true);
+    sc = getSearch<VectorType>(tv, filter);
     checkSearch(v, std::move(sc), 977, 1022, 10, !filter, true);
     populate(tv, 2, 973, true);
     sc = getSearch<VectorType>(tv, true);
     checkSearch(v, std::move(sc), 2, 1022, 205, !fastSearch && !filter, true);
     addDocs(v, 15000);
-    sc = getSearch<VectorType>(tv, true);
+    sc = getSearch<VectorType>(tv, filter);
     checkSearch(v, std::move(sc), 2, 1022, 205, !filter, true);
     populateAll(tv, 10, 15000, true);
     sc = getSearch<VectorType>(tv, true);
-- 
cgit v1.2.3