From 8dca74eb0879fe0e530c783d74a355747422aeec Mon Sep 17 00:00:00 2001
From: Tor Egge <Tor.Egge@online.no>
Date: Tue, 31 Jan 2023 12:46:10 +0100
Subject: Use snprintf instead of sprintf.

---
 searchsummary/src/vespa/juniper/Matcher.cpp | 13 ++++++++-----
 searchsummary/src/vespa/juniper/mcand.cpp   |  6 +++---
 2 files changed, 11 insertions(+), 8 deletions(-)

(limited to 'searchsummary/src')

diff --git a/searchsummary/src/vespa/juniper/Matcher.cpp b/searchsummary/src/vespa/juniper/Matcher.cpp
index 9f7db56823a..22d1bbc7e96 100644
--- a/searchsummary/src/vespa/juniper/Matcher.cpp
+++ b/searchsummary/src/vespa/juniper/Matcher.cpp
@@ -375,8 +375,9 @@ void Matcher::log_matches(int printcount)
     _log_text.append("<table>");
     if (m.size() > 0) {
         _log_text.append("<tr class=shade>");
-        sprintf(buf, "<td colspan=%d align=center><b>Topmost %zu matches out of %zu",
-                nterms+2, std::min(static_cast<size_t>(printcount), m.size()),m.size());
+        snprintf(buf, sizeof(buf),
+                 "<td colspan=%d align=center><b>Topmost %zu matches out of %zu",
+                 nterms+2, std::min(static_cast<size_t>(printcount), m.size()),m.size());
         _log_text.append(buf);
         _log_text.append("</b></td></tr>");
     }
@@ -399,12 +400,14 @@ void Matcher::log_matches(int printcount)
         }
     }
     _log_text.append("<tr class=shadehead>");
-    sprintf(buf, "<td colspan=%d align=center><b>Total(exact) keyword hits</b></td>",
-            nterms);
+    snprintf(buf, sizeof(buf),
+             "<td colspan=%d align=center><b>Total(exact) keyword hits</b></td>",
+             nterms);
     _log_text.append(buf);
     _log_text.append("</tr><tr class=shade>");
     for (i = 0; i < nterms; i++) {
-        sprintf(buf, "<td>%d(%d)</td>", TotalMatchCnt(i), ExactMatchCnt(i));
+        snprintf(buf, sizeof(buf),
+                 "<td>%d(%d)</td>", TotalMatchCnt(i), ExactMatchCnt(i));
         _log_text.append(buf);
     }
     _log_text.append("</tr></table>");
diff --git a/searchsummary/src/vespa/juniper/mcand.cpp b/searchsummary/src/vespa/juniper/mcand.cpp
index f67788d59ed..e30a0f42d1d 100644
--- a/searchsummary/src/vespa/juniper/mcand.cpp
+++ b/searchsummary/src/vespa/juniper/mcand.cpp
@@ -159,14 +159,14 @@ void MatchCandidate::log(std::string& logobj)
     {
         if (element[i])
         {
-            sprintf(buf, "<td align=left>%" PRId64 "</td>",
-                    static_cast<int64_t>(element[i]->starttoken()));
+            snprintf(buf, sizeof(buf), "<td align=left>%" PRId64 "</td>",
+                     static_cast<int64_t>(element[i]->starttoken()));
             logobj.append(buf);
         }
         else
             logobj.append("<td></td>");
     }
-    sprintf(buf, "<td align=right>%d</td><td align=right>%d</td>", word_distance(),rank());
+    snprintf(buf, sizeof(buf), "<td align=right>%d</td><td align=right>%d</td>", word_distance(),rank());
     logobj.append(buf);
 }
 
-- 
cgit v1.2.3