From 17d1bada57bf545687b88be0098cfe0722417cfb Mon Sep 17 00:00:00 2001 From: Jon Bratseth Date: Mon, 11 Sep 2017 13:03:25 +0200 Subject: Nonfunctional changes only --- .../com/yahoo/metrics/simple/UntypedMetric.java | 45 ++++++++++++---------- .../com/yahoo/metrics/simple/package-info.java | 2 +- 2 files changed, 25 insertions(+), 22 deletions(-) (limited to 'simplemetrics/src/main/java') diff --git a/simplemetrics/src/main/java/com/yahoo/metrics/simple/UntypedMetric.java b/simplemetrics/src/main/java/com/yahoo/metrics/simple/UntypedMetric.java index 731ef633f94..3a9f71b932c 100644 --- a/simplemetrics/src/main/java/com/yahoo/metrics/simple/UntypedMetric.java +++ b/simplemetrics/src/main/java/com/yahoo/metrics/simple/UntypedMetric.java @@ -11,9 +11,10 @@ import com.yahoo.log.LogLevel; * A gauge or a counter or... who knows? The class for storing a metric when the * metric has not been declared. * - * @author Steinar Knutsen + * @author Steinar Knutsen */ public class UntypedMetric { + private static final Logger log = Logger.getLogger(UntypedMetric.class.getName()); private long count = 0L; @@ -27,26 +28,6 @@ public class UntypedMetric { public enum AssumedType { NONE, GAUGE, COUNTER }; - public String toString() { - StringBuilder buf = new StringBuilder(); - buf.append(this.getClass().getName()).append(": "); - buf.append("outputFormat=").append(outputFormat).append(", "); - if (count > 0 && outputFormat == AssumedType.GAUGE) { - buf.append("max=").append(max).append(", "); - buf.append("min=").append(min).append(", "); - buf.append("sum=").append(sum).append(", "); - } - if (histogram != null) { - buf.append("histogram=").append(histogram).append(", "); - } - if (metricSettings != null) { - buf.append("metricSettings=").append(metricSettings).append(", "); - } - buf.append("current=").append(current).append(", "); - buf.append("count=").append(count); - return buf.toString(); - } - UntypedMetric(MetricSettings metricSettings) { this.metricSettings = metricSettings; if (metricSettings == null || !metricSettings.isHistogram()) { @@ -128,4 +109,26 @@ public class UntypedMetric { public DoubleHistogram getHistogram() { return histogram; } + + @Override + public String toString() { + StringBuilder buf = new StringBuilder(); + buf.append(this.getClass().getName()).append(": "); + buf.append("outputFormat=").append(outputFormat).append(", "); + if (count > 0 && outputFormat == AssumedType.GAUGE) { + buf.append("max=").append(max).append(", "); + buf.append("min=").append(min).append(", "); + buf.append("sum=").append(sum).append(", "); + } + if (histogram != null) { + buf.append("histogram=").append(histogram).append(", "); + } + if (metricSettings != null) { + buf.append("metricSettings=").append(metricSettings).append(", "); + } + buf.append("current=").append(current).append(", "); + buf.append("count=").append(count); + return buf.toString(); + } + } diff --git a/simplemetrics/src/main/java/com/yahoo/metrics/simple/package-info.java b/simplemetrics/src/main/java/com/yahoo/metrics/simple/package-info.java index efa01121e04..9306c7c59db 100644 --- a/simplemetrics/src/main/java/com/yahoo/metrics/simple/package-info.java +++ b/simplemetrics/src/main/java/com/yahoo/metrics/simple/package-info.java @@ -23,7 +23,7 @@ * {@link com.yahoo.metrics.simple.MetricUpdater}. *

* - * @author Steinar Knutsen + * @author Steinar Knutsen */ @PublicApi @ExportPackage -- cgit v1.2.3