From 5a99a68293d1a4b5f56e71e81b04398c2a3c967c Mon Sep 17 00:00:00 2001 From: Arne H Juul Date: Thu, 16 Sep 2021 08:57:32 +0000 Subject: always run with new logic * we decided to avoid any warnings on unregister, so update unit test accordingly. --- slobrok/src/tests/standalone/standalone.cpp | 4 ++-- slobrok/src/vespa/slobrok/server/sbenv.cpp | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'slobrok') diff --git a/slobrok/src/tests/standalone/standalone.cpp b/slobrok/src/tests/standalone/standalone.cpp index 883aeed1494..bee3bed71c3 100644 --- a/slobrok/src/tests/standalone/standalone.cpp +++ b/slobrok/src/tests/standalone/standalone.cpp @@ -281,13 +281,13 @@ TEST("standalone") { ASSERT_TRUE(req->GetReturn()->GetValue(0)._string_array._len == 0); ASSERT_TRUE(req->GetReturn()->GetValue(1)._string_array._len == 0); - // unregister server A (wrong spec) + // unregister server A (wrong spec, but we decided that is not an error) req = orb.AllocRPCRequest(req); req->SetMethodName("slobrok.unregisterRpcServer"); req->GetParams()->AddString("A"); req->GetParams()->AddString("tcp/localhost:18543"); sb->InvokeSync(req, 5.0); - ASSERT_TRUE(req->IsError()); + ASSERT_FALSE(req->IsError()); // lookup 'A' should give 'A' req = orb.AllocRPCRequest(req); diff --git a/slobrok/src/vespa/slobrok/server/sbenv.cpp b/slobrok/src/vespa/slobrok/server/sbenv.cpp index ebb9935877f..4bd55ee67f4 100644 --- a/slobrok/src/vespa/slobrok/server/sbenv.cpp +++ b/slobrok/src/vespa/slobrok/server/sbenv.cpp @@ -97,15 +97,15 @@ ConfigTask::PerformTask() } // namespace slobrok:: -SBEnv::SBEnv(const ConfigShim &shim) : SBEnv(shim, false) {} +SBEnv::SBEnv(const ConfigShim &shim) : SBEnv(shim, true) {} -SBEnv::SBEnv(const ConfigShim &shim, bool useNewConsensusLogic) +SBEnv::SBEnv(const ConfigShim &shim, bool) : _transport(std::make_unique(TransportConfig().drop_empty_buffers(true))), _supervisor(std::make_unique(_transport.get())), _configShim(shim), _configurator(shim.factory().create(*this)), _shuttingDown(false), - _useNewLogic(useNewConsensusLogic), + _useNewLogic(true), _partnerList(), _me(createSpec(_configShim.portNumber())), _rpcHooks(*this, _rpcsrvmap, _rpcsrvmanager), -- cgit v1.2.3