From 23899cf262fee4bca3f92c25e85a4d269ad56161 Mon Sep 17 00:00:00 2001 From: Tor Egge Date: Tue, 12 Oct 2021 12:51:26 +0200 Subject: Update metrics when we don't have source-only bucket copies. --- .../storage/distributor/operations/idealstate/mergeoperation.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'storage') diff --git a/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp b/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp index 7008cb36666..69bbb67b1f3 100644 --- a/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp +++ b/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp @@ -248,9 +248,9 @@ MergeOperation::deleteSourceOnlyNodes( _ok = _removeOperation->ok(); done(); } + } else { + done(); } - // FIXME what about the else-case here...? done() is not invoked by caller in this branch. - // Not calling done() doesn't leak anything, but causes metric updates to be missed. } void -- cgit v1.2.3