From 761041825bf2a01520d05ddca928182dfc798911 Mon Sep 17 00:00:00 2001 From: HÃ¥vard Pettersen Date: Fri, 29 Sep 2017 15:08:18 +0000 Subject: avoid implicit cast to bool --- storage/src/tests/common/hostreporter/util.cpp | 2 +- storage/src/tests/storageserver/statereportertest.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'storage') diff --git a/storage/src/tests/common/hostreporter/util.cpp b/storage/src/tests/common/hostreporter/util.cpp index ad4931cb15f..e0563a431e6 100644 --- a/storage/src/tests/common/hostreporter/util.cpp +++ b/storage/src/tests/common/hostreporter/util.cpp @@ -26,7 +26,7 @@ reporterToSlime(HostReporter &hostReporter, vespalib::Slime &slime) { std::string jsonData = json.str(); size_t parsed = JsonFormat::decode(Memory(jsonData), slime); - if (!parsed) { + if (parsed == 0) { CPPUNIT_FAIL("jsonData is not json:\n" + jsonData); } } diff --git a/storage/src/tests/storageserver/statereportertest.cpp b/storage/src/tests/storageserver/statereportertest.cpp index 32bc0ded492..3a71444e74c 100644 --- a/storage/src/tests/storageserver/statereportertest.cpp +++ b/storage/src/tests/storageserver/statereportertest.cpp @@ -130,7 +130,7 @@ vespalib::Slime slime; \ size_t parsed = JsonFormat::decode(vespalib::Memory(jsonData), slime); \ vespalib::SimpleBuffer buffer; \ JsonFormat::encode(slime, buffer, false); \ - if (!parsed) { \ + if (parsed == 0) { \ std::ostringstream error; \ error << "Failed to parse JSON: '\n" \ << jsonData << "'\n:" << buffer.get().make_string() << "\n"; \ -- cgit v1.2.3