From 95de10788c5f5a1c60e80e312091ed05b01a26fd Mon Sep 17 00:00:00 2001
From: Henning Baldersheim <balder@yahoo-inc.com>
Date: Mon, 23 Nov 2020 10:24:08 +0000
Subject: Only copy tracelevel.

---
 storageapi/src/vespa/storageapi/messageapi/storagecommand.cpp | 6 ------
 storageapi/src/vespa/storageapi/messageapi/storagemessage.cpp | 2 +-
 storageapi/src/vespa/storageapi/messageapi/storagemessage.h   | 2 +-
 3 files changed, 2 insertions(+), 8 deletions(-)

(limited to 'storageapi')

diff --git a/storageapi/src/vespa/storageapi/messageapi/storagecommand.cpp b/storageapi/src/vespa/storageapi/messageapi/storagecommand.cpp
index 82d3dd8f6a8..397c869f4fb 100644
--- a/storageapi/src/vespa/storageapi/messageapi/storagecommand.cpp
+++ b/storageapi/src/vespa/storageapi/messageapi/storagecommand.cpp
@@ -11,12 +11,6 @@ StorageCommand::StorageCommand(const StorageCommand& other)
       _timeout(other._timeout),
       _sourceIndex(other._sourceIndex)
 {
-    // TODD do we really need copy construction, seems only use by CreateVisitorCommand ?
-    if ( !other.getTrace().isEmpty()) {
-        setTrace(vespalib::Trace(other.getTrace()));
-    } else {
-        getTrace().setLevel(other.getTrace().getLevel());
-    }
 }
 
 StorageCommand::StorageCommand(const MessageType& type, Priority p)
diff --git a/storageapi/src/vespa/storageapi/messageapi/storagemessage.cpp b/storageapi/src/vespa/storageapi/messageapi/storagemessage.cpp
index cc62e6664e0..700669739ce 100644
--- a/storageapi/src/vespa/storageapi/messageapi/storagemessage.cpp
+++ b/storageapi/src/vespa/storageapi/messageapi/storagemessage.cpp
@@ -282,7 +282,7 @@ StorageMessage::StorageMessage(const StorageMessage& other, Id id)
       _msgId(id),
       _address(),
       _loadType(other._loadType),
-      _trace(),
+      _trace(other.getTrace().getLevel()),
       _approxByteSize(other._approxByteSize),
       _priority(other._priority)
 {
diff --git a/storageapi/src/vespa/storageapi/messageapi/storagemessage.h b/storageapi/src/vespa/storageapi/messageapi/storagemessage.h
index 9135a6619ef..136972f67a5 100644
--- a/storageapi/src/vespa/storageapi/messageapi/storagemessage.h
+++ b/storageapi/src/vespa/storageapi/messageapi/storagemessage.h
@@ -362,7 +362,7 @@ protected:
     Id                 _msgId;
     std::unique_ptr<StorageMessageAddress> _address;
     documentapi::LoadType _loadType;
-    vespalib::Trace _trace;
+    vespalib::Trace       _trace;
     uint32_t    _approxByteSize;
     Priority    _priority;
 
-- 
cgit v1.2.3