From 0aade2bf351d67e56eea952211ee28efc87d2f5f Mon Sep 17 00:00:00 2001 From: Tor Brede Vekterli Date: Fri, 17 Apr 2020 19:24:56 +0000 Subject: Remove test of error handling anti-pattern Invariant violations should be assertions and not exceptions, so no point in testing that this is handled gracefully. --- storageframework/src/tests/thread/tickingthreadtest.cpp | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'storageframework') diff --git a/storageframework/src/tests/thread/tickingthreadtest.cpp b/storageframework/src/tests/thread/tickingthreadtest.cpp index c42a9c17283..f69f77e8a07 100644 --- a/storageframework/src/tests/thread/tickingthreadtest.cpp +++ b/storageframework/src/tests/thread/tickingthreadtest.cpp @@ -234,21 +234,6 @@ TEST(TickingThreadTest, test_lock_critical_ticks) } } -TEST(TickingThreadTest, test_fails_on_start_without_threads) -{ - TestComponentRegister testReg( - ComponentRegisterImpl::UP(new ComponentRegisterImpl)); - int threadCount = 0; - MyApp app(threadCount, true); - try{ - app.start(testReg.getThreadPoolImpl()); - FAIL() << "Expected starting without threads to fail"; - } catch (vespalib::Exception& e) { - EXPECT_EQ(vespalib::string("Makes no sense to start threadpool without threads"), - e.getMessage()); - } -} - namespace { RealClock clock; -- cgit v1.2.3