From 9474bc887920ed2a080548d416da4751c065f789 Mon Sep 17 00:00:00 2001 From: Jon Marius Venstad Date: Wed, 17 Nov 2021 14:13:01 +0100 Subject: Unify test runner interfaces and simplify --- .../main/java/com/yahoo/vespa/hosted/testrunner/TestRunner.java | 3 +-- .../java/com/yahoo/vespa/hosted/testrunner/TestRunnerHandler.java | 8 ++++---- .../java/com/yahoo/vespa/hosted/testrunner/TestRunnerTest.java | 5 ++--- 3 files changed, 7 insertions(+), 9 deletions(-) (limited to 'vespa-testrunner-components') diff --git a/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunner.java b/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunner.java index f31390e9933..8aa2cd7bc72 100644 --- a/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunner.java +++ b/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunner.java @@ -3,7 +3,6 @@ package com.yahoo.vespa.hosted.testrunner; import com.google.inject.Inject; import com.yahoo.vespa.defaults.Defaults; -import com.yahoo.vespa.testrunner.legacy.LegacyTestRunner; import org.fusesource.jansi.AnsiOutputStream; import org.fusesource.jansi.HtmlAnsiOutputStream; @@ -37,7 +36,7 @@ import static java.util.logging.Level.SEVERE; * @author valerijf * @author jvenstad */ -public class TestRunner implements LegacyTestRunner { +public class TestRunner implements com.yahoo.vespa.testrunner.TestRunner { private static final Logger logger = Logger.getLogger(TestRunner.class.getName()); private static final Level HTML = new Level("html", 1) { }; diff --git a/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunnerHandler.java b/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunnerHandler.java index 842fc5078c1..f9deef0bfd2 100644 --- a/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunnerHandler.java +++ b/vespa-testrunner-components/src/main/java/com/yahoo/vespa/hosted/testrunner/TestRunnerHandler.java @@ -11,7 +11,7 @@ import com.yahoo.io.IOUtils; import com.yahoo.slime.Cursor; import com.yahoo.slime.JsonFormat; import com.yahoo.slime.Slime; -import com.yahoo.vespa.testrunner.legacy.LegacyTestRunner; +import com.yahoo.vespa.testrunner.TestRunner; import com.yahoo.yolean.Exceptions; import java.io.ByteArrayOutputStream; @@ -33,10 +33,10 @@ public class TestRunnerHandler extends LoggingRequestHandler { private static final String CONTENT_TYPE_APPLICATION_JSON = "application/json"; - private final TestRunner testRunner; + private final com.yahoo.vespa.hosted.testrunner.TestRunner testRunner; @Inject - public TestRunnerHandler(Executor executor, TestRunner testRunner) { + public TestRunnerHandler(Executor executor, com.yahoo.vespa.hosted.testrunner.TestRunner testRunner) { super(executor); this.testRunner = testRunner; } @@ -75,7 +75,7 @@ public class TestRunnerHandler extends LoggingRequestHandler { final String path = request.getUri().getPath(); if (path.startsWith("/tester/v1/run/")) { String type = lastElement(path); - LegacyTestRunner.Suite suite = LegacyTestRunner.Suite.valueOf(type.toUpperCase() + "_TEST"); + TestRunner.Suite suite = TestRunner.Suite.valueOf(type.toUpperCase() + "_TEST"); byte[] config = IOUtils.readBytes(request.getData(), 1 << 16); testRunner.test(suite, config); log.info("Started tests of type " + type + " and status is " + testRunner.getStatus()); diff --git a/vespa-testrunner-components/src/test/java/com/yahoo/vespa/hosted/testrunner/TestRunnerTest.java b/vespa-testrunner-components/src/test/java/com/yahoo/vespa/hosted/testrunner/TestRunnerTest.java index 68fa5427492..b513dfba8b5 100644 --- a/vespa-testrunner-components/src/test/java/com/yahoo/vespa/hosted/testrunner/TestRunnerTest.java +++ b/vespa-testrunner-components/src/test/java/com/yahoo/vespa/hosted/testrunner/TestRunnerTest.java @@ -1,7 +1,6 @@ // Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. package com.yahoo.vespa.hosted.testrunner; -import com.yahoo.vespa.testrunner.legacy.LegacyTestRunner; import org.fusesource.jansi.Ansi; import org.junit.Before; import org.junit.Rule; @@ -14,8 +13,8 @@ import java.nio.file.Path; import java.util.Iterator; import java.util.logging.LogRecord; -import static com.yahoo.vespa.testrunner.legacy.LegacyTestRunner.Suite.STAGING_TEST; -import static com.yahoo.vespa.testrunner.legacy.LegacyTestRunner.Suite.SYSTEM_TEST; +import static com.yahoo.vespa.testrunner.TestRunner.Suite.STAGING_TEST; +import static com.yahoo.vespa.testrunner.TestRunner.Suite.SYSTEM_TEST; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -- cgit v1.2.3