From 71608598e54b6e2a095db24d2a27f74475daeb46 Mon Sep 17 00:00:00 2001
From: Henning Baldersheim <balder@yahoo-inc.com>
Date: Thu, 26 Jan 2023 12:05:48 +0100
Subject: Minor code cleanup.

---
 .../status/FileDistributionStatusClient.java       | 30 +++++++++-------------
 1 file changed, 12 insertions(+), 18 deletions(-)

(limited to 'vespaclient-java/src')

diff --git a/vespaclient-java/src/main/java/com/yahoo/vespa/filedistribution/status/FileDistributionStatusClient.java b/vespaclient-java/src/main/java/com/yahoo/vespa/filedistribution/status/FileDistributionStatusClient.java
index a9bbfafeaf0..249432804ad 100644
--- a/vespaclient-java/src/main/java/com/yahoo/vespa/filedistribution/status/FileDistributionStatusClient.java
+++ b/vespaclient-java/src/main/java/com/yahoo/vespa/filedistribution/status/FileDistributionStatusClient.java
@@ -74,15 +74,13 @@ public class FileDistributionStatusClient {
     private String doHttpRequest() {
         Timeout timeoutInMillis = Timeout.ofMilliseconds((long) (timeout * 1000));
         RequestConfig config = custom()
-                .setConnectTimeout(timeoutInMillis)
                 .setConnectionRequestTimeout(timeoutInMillis)
                 .setResponseTimeout(timeoutInMillis)
                 .build();
-        CloseableHttpClient httpClient = VespaHttpClientBuilder.create().build();
-        URI statusUri = createStatusApiUri();
-        if (debug)
-            System.out.println("URI:" + statusUri);
-        try {
+        try (CloseableHttpClient httpClient =  VespaHttpClientBuilder.create().build()) {
+            URI statusUri = createStatusApiUri();
+            if (debug)
+                System.out.println("URI:" + statusUri);
             HttpGet request = new HttpGet(statusUri);
             request.addHeader("Connection", "Close");
             request.setConfig(config);
@@ -95,7 +93,7 @@ public class FileDistributionStatusClient {
                 return content;
             } else {
                 throw new RuntimeException("Failed to get status for request " + statusUri + ": " +
-                                                   response.getCode() + ": " + content);
+                        response.getCode() + ": " + content);
             }
         } catch (IOException | ParseException e) {
             throw new RuntimeException(e);
@@ -111,16 +109,12 @@ public class FileDistributionStatusClient {
             throw new RuntimeException(e);
         }
         String status = jsonNode.get("status").asText();
-        switch (status) {
-            case statusUnknown:
-                return "File distribution status unknown: " + jsonNode.get("message").asText();
-            case statusInProgress:
-                return "File distribution in progress:\n" + inProgressOutput(jsonNode.get("hosts"));
-            case statusFinished:
-                return "File distribution finished";
-            default:
-                throw new RuntimeException("Unknown status " + status);
-        }
+        return switch (status) {
+            case statusUnknown -> "File distribution status unknown: " + jsonNode.get("message").asText();
+            case statusInProgress -> "File distribution in progress:\n" + inProgressOutput(jsonNode.get("hosts"));
+            case statusFinished -> "File distribution finished";
+            default -> throw new RuntimeException("Unknown status " + status);
+        };
     }
 
     private URI createStatusApiUri() {
@@ -158,7 +152,7 @@ public class FileDistributionStatusClient {
                                 finished++;
                         }
                     }
-                    sb.append(" (" + finished + " of " + fileReferencesArray.size() + " finished)");
+                    sb.append(" (").append(finished).append(" of ").append(fileReferencesArray.size()).append(" finished)");
                     break;
                 case statusFinished:
                     break; // Nothing to add
-- 
cgit v1.2.3