From 4ea035b70e31781783113a4b6eb56c21c7c02bf3 Mon Sep 17 00:00:00 2001
From: Øyvind Grønnesby <oyving@yahooinc.com>
Date: Mon, 12 Dec 2022 16:50:14 +0100
Subject: Create a metric for maintainer execution time

---
 .../java/com/yahoo/concurrent/maintenance/JobMetrics.java     |  2 +-
 .../java/com/yahoo/concurrent/maintenance/Maintainer.java     | 11 ++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

(limited to 'vespajlib/src/main')

diff --git a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/JobMetrics.java b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/JobMetrics.java
index 705176e8f3e..60d66ae4d91 100644
--- a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/JobMetrics.java
+++ b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/JobMetrics.java
@@ -14,6 +14,6 @@ public abstract class JobMetrics {
      * Records completion of a run of a job.
      * This is guaranteed to always be called once after each maintainer run.
      */
-    public abstract void completed(String job, double successFactor);
+    public abstract void completed(String job, double successFactor, long durationMs);
 
 }
diff --git a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
index b038106843e..1e2c0900ff7 100644
--- a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
+++ b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
@@ -6,6 +6,7 @@ import com.yahoo.net.HostName;
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
+import java.time.Clock;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
@@ -35,15 +36,17 @@ public abstract class Maintainer implements Runnable {
     private final ScheduledExecutorService service;
     private final AtomicBoolean shutDown = new AtomicBoolean();
     private final boolean ignoreCollision;
+    private final Clock clock;
 
-    public Maintainer(String name, Duration interval, Instant startedAt, JobControl jobControl,
+    public Maintainer(String name, Duration interval, Clock clock, JobControl jobControl,
                       JobMetrics jobMetrics, List<String> clusterHostnames, boolean ignoreCollision) {
         this.name = name;
         this.interval = requireInterval(interval);
         this.jobControl = Objects.requireNonNull(jobControl);
         this.jobMetrics = Objects.requireNonNull(jobMetrics);
         this.ignoreCollision = ignoreCollision;
-        Objects.requireNonNull(startedAt);
+        this.clock = clock;
+        var startedAt = clock.instant();
         Objects.requireNonNull(clusterHostnames);
         Duration initialDelay = staggeredDelay(interval, startedAt, HostName.getLocalhost(), clusterHostnames)
                                 .plus(Duration.ofSeconds(30)); // Let the system stabilize before maintenance
@@ -109,6 +112,7 @@ public abstract class Maintainer implements Runnable {
         log.log(Level.FINE, () -> "Running " + this.getClass().getSimpleName());
 
         double successFactor = 0;
+        long startTime = clock.millis();
         try (var lock = jobControl.lockJob(name())) {
             successFactor = maintain();
         }
@@ -122,7 +126,8 @@ public abstract class Maintainer implements Runnable {
             log.log(Level.WARNING, this + " failed. Will retry in " + interval, e);
         }
         finally {
-            jobMetrics.completed(name(), successFactor);
+            long endTime = clock.millis();
+            jobMetrics.completed(name(), successFactor, endTime - startTime);
         }
         log.log(Level.FINE, () -> "Finished " + this.getClass().getSimpleName());
     }
-- 
cgit v1.2.3